-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code-first support #18
Comments
Thanks for the kind words! Looks like the client side is simple for both (just use NamedPipeChannel in place of
As far as MagicOnion, I haven't dived into it, but there should be something roughly equivalent. Conceptually the idea is that you need to create a NamedPipeServer and then use its ServiceBinder to map service method descriptions to implementations. I'm also open to PRs that tweak the API if that makes it easier. |
Sorry for my delay, but I have been very busy. |
@cyanfish I was looking at this repository and I am curious to know why a CustomSerializer was added while upgrading the grpc packages instead of relying on the marshaller.Serializer. Any particular reason for the change ? |
@ashisha690 I don't know if there's a way to change it but the gRPC-generated marshaller doesn't implement |
@cyanfish in old versions it seems to be supported. And I didnt find in there release notes if the support of Serializer was deprecated. |
Hello,
I want to congratulate with the author for this ingenious project. I compared with the official version which uses UnixSocket and this one is much faster. I couldn't understand why this has not been merged into the official!
I am trying to implement your lib in MagicOnion, but I can't find a BinderService. I like the fact that it supports MessagePack and code-first support, but it still rely on Http/2 and is slower. Another one is protobuf-net.Grpc.
Is there a way to make it work with these two frameworks?
The text was updated successfully, but these errors were encountered: