From a7ea5b3fa94d4f4cc1f3d4935cf6629339063072 Mon Sep 17 00:00:00 2001 From: Pokey Rule <755842+pokey@users.noreply.github.com> Date: Thu, 18 Apr 2024 18:17:19 +0100 Subject: [PATCH 1/2] Add debug logging --- .../src/launchVscodeAndRunTests.ts | 34 +++++++++++-------- 1 file changed, 20 insertions(+), 14 deletions(-) diff --git a/packages/test-harness/src/launchVscodeAndRunTests.ts b/packages/test-harness/src/launchVscodeAndRunTests.ts index be2c0958be..d20d7a69ac 100644 --- a/packages/test-harness/src/launchVscodeAndRunTests.ts +++ b/packages/test-harness/src/launchVscodeAndRunTests.ts @@ -41,20 +41,26 @@ export async function launchVscodeAndRunTests(extensionTestsPath: string) { resolveCliArgsFromVSCodeExecutablePath(vscodeExecutablePath); // Install extension dependencies - cp.spawnSync( - cli, - [ - ...args, - ...extensionDependencies.flatMap((dependency) => [ - "--install-extension", - dependency, - ]), - ], - { - encoding: "utf-8", - stdio: "inherit", - }, - ); + const extensionInstallArgs = [ + ...args, + ...extensionDependencies.flatMap((dependency) => [ + "--install-extension", + dependency, + ]), + ]; + + console.log("starting to install dependency extensions"); + console.log(`cli: ${cli}`); + console.log(JSON.stringify(extensionInstallArgs, null, 2)); + + const { status, signal, error } = cp.spawnSync(cli, extensionInstallArgs, { + encoding: "utf-8", + stdio: "inherit", + }); + + console.log("status: ", status); + console.log("signal: ", signal); + console.log("error: ", error); console.log("finished installing dependency extensions"); From f21243e44842155fdc631b2593c2bda86fa3bb57 Mon Sep 17 00:00:00 2001 From: Pokey Rule <755842+pokey@users.noreply.github.com> Date: Thu, 18 Apr 2024 18:21:32 +0100 Subject: [PATCH 2/2] Pin node version --- .github/workflows/deploy.yaml | 2 +- .github/workflows/pre-commit.yml | 2 +- .github/workflows/test-docs.yml | 2 +- .github/workflows/test.yml | 2 +- .nvmrc | 1 + 5 files changed, 5 insertions(+), 4 deletions(-) create mode 100644 .nvmrc diff --git a/.github/workflows/deploy.yaml b/.github/workflows/deploy.yaml index 6ac98093fb..c9ac7ea536 100644 --- a/.github/workflows/deploy.yaml +++ b/.github/workflows/deploy.yaml @@ -20,7 +20,7 @@ jobs: - run: corepack enable - uses: actions/setup-node@v4 with: - node-version-file: package.json + node-version-file: .nvmrc cache: pnpm - run: pnpm --color install - run: pnpm --color compile diff --git a/.github/workflows/pre-commit.yml b/.github/workflows/pre-commit.yml index 6ce57b6e06..8ab2696c91 100644 --- a/.github/workflows/pre-commit.yml +++ b/.github/workflows/pre-commit.yml @@ -21,7 +21,7 @@ jobs: - run: corepack enable - uses: actions/setup-node@v4 with: - node-version-file: package.json + node-version-file: .nvmrc cache: pnpm - run: pnpm --color install - uses: pre-commit/action@v3.0.0 diff --git a/.github/workflows/test-docs.yml b/.github/workflows/test-docs.yml index ae2ce4c03a..31a583abfc 100644 --- a/.github/workflows/test-docs.yml +++ b/.github/workflows/test-docs.yml @@ -16,6 +16,6 @@ jobs: - run: corepack enable - uses: actions/setup-node@v4 with: - node-version-file: package.json + node-version-file: .nvmrc cache: pnpm - run: bash -x scripts/build-and-assemble-website.sh diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index de58a90b91..df66cba4bf 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -31,7 +31,7 @@ jobs: - run: corepack enable - uses: actions/setup-node@v4 with: - node-version-file: package.json + node-version-file: .nvmrc cache: pnpm - run: mkdir -p "${{ env.VSCODE_CRASH_DIR }}" "${{ env.VSCODE_LOGS_DIR }}" shell: bash diff --git a/.nvmrc b/.nvmrc new file mode 100644 index 0000000000..020fc41da2 --- /dev/null +++ b/.nvmrc @@ -0,0 +1 @@ +v20.12.1