Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate why partial type definition being coalesced to non partial isn't a TypeScript compiler #2743

Open
phillco opened this issue Jan 21, 2025 · 2 comments
Open

Investigate why partial type definition being coalesced to non partial isn't a TypeScript compiler #2743

phillco opened this issue Jan 21, 2025 · 2 comments
Assignees
@AndreasArvidsson

Comments

@phillco
Copy link
Member

phillco commented Jan 21, 2025

NTS: The actual type of the interface is requirements?: Partial<ScopeIteratorRequirements>. This should really be a tsc compile error but it wasn't. We therefore started to read properties on hints when some of those properties could be undefined which threw an exception

Originally posted by @phillco in #2739 (comment)
@phillco
Copy link
Member Author

phillco commented Jan 21, 2025

Just flagging for passive followup later

@AndreasArvidsson
Copy link
Member

I created the smallest possible example. No warnings from typescript.

#2745

@AndreasArvidsson AndreasArvidsson mentioned this issue Jan 21, 2025
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AndreasArvidsson AndreasArvidsson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@phillco @AndreasArvidsson