-
-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate Cursorless snippet format in favour of community snippets #2353
Comments
What do you think about having the migrate command optionally migrate to the directory specified as the user's snippets directory? (In case folks want to keep snippets outside of community). Asking for others like me, since I don't need to migrate 😀 |
If you have a custom snippets directory, then yes that's where they'll end up |
Awesome, thank you. |
@AndreasArvidsson reading this one again, I think this change would make the entire So the only place we'd be using the file system would be for "snip make", but we can figure out a way to make that work. The key thing is that we will no longer need a I guess there's the issue of Cursorless keyboard, but we could probably make that work external to the engine, the way the rest of cursorless keyboard-specific stuff is done in vscode side today |
Unless we want to support named snippets for Cursorless keyboard, then yes. That sounds correct. |
Yeah I think if we wanted to support named snippets with keyboard we'd do it external to engine, like the rest of keyboard support |
Then there is no problem :) |
After discussing this with @AndreasArvidsson, we've updated the list of planned items in the description. At this time we are not planning to make a dedicated third extension for VS Code functionality for snippets specifically, because we don't have the time/CI expertise/etc, so Andreas is going to put those two pieces (type hinting and autoformatting) into his extension, since they are nice to haves and not requirements. Down the line, we do see a place for a "Talon [Contrib] VS Code" extension that would do these things alongside things like automatically formatting the treesitter scope format, which isn't somebody's personal extension, once usage of these features merits it. I think one thing that we do agree on is that these small individual pieces don't merit individual extensions, this raises the overhead of maintenance to be too high. But a common "contrib" extension makes sense. |
…pets (#2804) #2353 The Cursorless side of talonhub/community#1718 Will allow Cursorless to fetch multiple snippets from community and decide which one to use. ## Release notes Cursorless can now get multiple snippets from community. One for each language. Cursorless can then pick the correct snippet for the document language regardless of which document is focused at the moment. --------- Co-authored-by: Phillip Cohen <[email protected]>
…pets (#2804) cursorless-dev/cursorless#2353 The Cursorless side of talonhub/community#1718 Will allow Cursorless to fetch multiple snippets from community and decide which one to use. ## Release notes Cursorless can now get multiple snippets from community. One for each language. Cursorless can then pick the correct snippet for the document language regardless of which document is focused at the moment. --------- Co-authored-by: Phillip Cohen <[email protected]>
…pets (#2804) #2353 The Cursorless side of talonhub/community#1718 Will allow Cursorless to fetch multiple snippets from community and decide which one to use. ## Release notes Cursorless can now get multiple snippets from community. One for each language. Cursorless can then pick the correct snippet for the document language regardless of which document is focused at the moment. --------- Co-authored-by: Phillip Cohen <[email protected]>
Later:
CustomInsertionSnippet
et all (most likely dropCustom
)Re-add functionality that was only supported by legacy snippets:
Tabled:
The text was updated successfully, but these errors were encountered: