Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove step number from Progress Formatter #671

Open
skiz opened this issue Dec 18, 2024 · 0 comments
Open

Remove step number from Progress Formatter #671

skiz opened this issue Dec 18, 2024 · 0 comments

Comments

@skiz
Copy link

skiz commented Dec 18, 2024

👓 What did you see?

When running numerous scenarios and using the progress formatter,
When the step is a mod of 70, the step numbers are printed on the progress line and a line break is introduced.
This seems to be only useful for debugging the formatter itself and should likely be removed.
Additionally, there should be a line break after each scenario is completed.

Current output:

.......=== RUN   TestFeatures/MyFeature1
........... 420
.=== RUN   TestFeatures/MyFeature2
........................=== RUN   TestFeatures/MyFeature3

Offending Line/Area:

if math.Mod(float64(*f.Steps), float64(f.StepsPerRow)) == 0 {

✅ What did you expect to see?

Expected output:

=== RUN   TestFeatures/MyFeature1
...........
=== RUN   TestFeatures/MyFeature2
........................
=== RUN   TestFeatures/MyFeature3

In the case of more than 70 steps per Scenario the output should expect to look like:

=== RUN   TestFeatures/MyFeature1
............................................................
............................................................
...........................................
=== RUN   TestFeatures/MyFeature2
............................................................
.........

📦 Which tool/library version are you using?

Golang Godog Main Branch

🔬 How could we reproduce it?

No response

📚 Any additional context?

I'll tackle this myself if this makes sense to others.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant