Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disconnect 3D puzzles from listeners as soon as the player puzzle changes. #164

Open
lgarron opened this issue Jan 7, 2022 · 0 comments
Labels
🐞 bug Something isn't working 📦 cubing/twisty good first issue Good for newcomers

Comments

@lgarron
Copy link
Member

lgarron commented Jan 7, 2022

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://alpha.twizzle.net/explore/?alg=%28U+F+R+D+B+L%29&puzzle=30x30x30
  2. Change the puzzle to 40x40x40lgarr

The 30x30x30 puzzle flashes a significantly more scrambled state, probably from reading a 40x40x40 state.
24567 @5 89

Expected behavior
The puzzle changes immediately, or at least doesn't show an inconsistent state.

I think this disconnection isn't doing its job:

this.#currentTwisty3DPuzzleWrapper?.disconnect();

@lgarron lgarron added 🐞 bug Something isn't working good first issue Good for newcomers 📦 cubing/twisty labels Jan 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working 📦 cubing/twisty good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant