Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TwistyAlgEditorV2: keep the timestamp at opposite-anchor #135

Open
lgarron opened this issue Aug 28, 2021 · 0 comments
Open

TwistyAlgEditorV2: keep the timestamp at opposite-anchor #135

lgarron opened this issue Aug 28, 2021 · 0 comments
Labels
🐞 bug Something isn't working 📦 cubing/twisty

Comments

@lgarron
Copy link
Member

lgarron commented Aug 28, 2021

To Reproduce
Steps to reproduce the behavior:

  1. Go to http://localhost:3333/alpha.twizzle.net/edit/?alg=R+U+R%27

The cursor jumps to 250ms, because <twisty-alg-editor-v2> is telling it that the cursor is at the beginning.

Expected behavior

The cursor should stay at the end of the alg.

This is not a huge deal, since alg.cubing.net doesn't even do this well. And I also felt comfortable merging to main with this bug in place. But I'd like to fix it as soon as possible.

This is probably not a good bug for someone else to tackle, since the current TwistyAlgEditorV2 code is not great:

/**
* Warning: the current implementation of <twisty-alg-editor-v2> is *not good*,
* but it is *good enough*. The important parts is that:
*
* - The editor can be used in apps without much effort.
* - The editor handles alg validation and move highlighting *okay* when not
* connected to a `<twisty-player-v2>`.
* - The editor stays in sync if it's connected to a `<twisty-player-v2>`.
*
* The current implementation still has some race conditions and edge cases. A
* proper rewrite with a better model would be very welcom.
*/

@lgarron lgarron added 🐞 bug Something isn't working 📦 cubing/twisty labels Aug 28, 2021
@lgarron lgarron changed the title Twizzle Editor: keep the timestamp at opposite-anchor. TwistyAlgEditorV2: keep the timestamp at opposite-anchor Aug 28, 2021
lgarron added a commit that referenced this issue Aug 28, 2021
This still has one known issue: #135
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working 📦 cubing/twisty
Projects
None yet
Development

No branches or pull requests

1 participant