Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various issues with 3D and resizing #12

Open
rokicki opened this issue Dec 7, 2019 · 1 comment
Open

Various issues with 3D and resizing #12

rokicki opened this issue Dec 7, 2019 · 1 comment

Comments

@rokicki
Copy link
Contributor

rokicki commented Dec 7, 2019

In Chrome (and not Safari or Firefox) if you resize too small, you get an unending series of increase size events that cause the rendered puzzle to "drop" out of the window.

In Safari (and not Chrome or Firefox), setting the aspect ratio doesn't work (resizing causes the cube to change aspect ratio).

In all browsers, when hitting the "full size" twisty button in the lower left, all UI elements except the twisty display and its controls disappear (so the alg input and the buttons on the top all go away).

@rokicki
Copy link
Contributor Author

rokicki commented Dec 9, 2019

The Safari aspect ratio problems are because we are using ResizeObserver and Safari doesn't implement this, so our resize code never gets called; instead our webgl is rendered to a canvas at the original size and scaled (ugly).

I have not yet figured out how to resolve the problem with Chrome looping when the canvas size gets too small.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants