Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contribution Proposal #2

Open
DhyeyAero95 opened this issue Nov 6, 2022 · 5 comments
Open

Contribution Proposal #2

DhyeyAero95 opened this issue Nov 6, 2022 · 5 comments

Comments

@DhyeyAero95
Copy link
Collaborator

Contact we made for upstream is in your email titled "CSCI-5636 Project".
image

@connorhorn26
Copy link

connorhorn26 commented Nov 29, 2022

"Pull Request"

The comparison between MORIS and MoFEM packages is attached below, also attached is CUBIT mesh input file for MORIS and MoFEM, MORIS input file, and MoFEM jupyter python script.

The MoFEM google mailing list has also been contacted regarding this comparison.

CSCI_5636.pdf
pullrequest.zip

@jedbrown
Copy link

Cool. The lack of convergence is concerning. Can you do a grid refinement study to see if MoFEM is converging at its design order of accuracy? Is MORIS converging to a wrong answer or not converging at all? I wonder if you can reduce that non-convergence phenomena.

How did you choose time steps?

@DhyeyAero95
Copy link
Collaborator Author

DhyeyAero95 commented Nov 30, 2022 via email

@jedbrown
Copy link

Okay, sounds good. I would compare time integrator and step size (match them if possible) and then solver configuration. You should be able to profile to see where the time is spent.

@DhyeyAero95
Copy link
Collaborator Author

"Pull Request" update:

As mentioned earlier, here are the updated report file and zip file consisting of important input and mesh and result files. In terms of solution field, result are very similar but MORIS outperforms MoFEM in terms of computation time however it depends on hardware we are using for both programs.

CSCI_5636.pdf
Pull_Request_Files.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants