Extract have something wrong

[EunChae1110]

I use libzippp to make extract. This is the code:

void ExtractZip(std::string path)
{
	ZipArchive zip(path);
	zip.open(ZipArchive::ReadOnly);
	std::vector<ZipEntry> entries = zip.getEntries();
	std::vector<ZipEntry>::iterator it;
	path = "./"+path.substr(0, path.find(".zip"));
	std::filesystem::create_directory(path);
	for (it = entries.begin(); it != entries.end(); ++it)
	{
		ZipEntry entry = *it;
		if (entry.isDirectory())
		{
			std::filesystem::create_directories(path+"\\"+entry.getName());
		}
		std::ofstream unzippedFile(path + "\\"+entry.getName());
		entry.readContent(unzippedFile);
		unzippedFile.close();
	}
	zip.close();
}

However, when I checked the file after extracted, the file destroyed.
Original file:

After extract:

[ctabin]

Hi @EunChae1110,
What about the zip ? If you extract the file with zip is it correct ?
Did you try with another extraction method ?
Can you provide a full test case ?
Thanks.

[EunChae1110]

Because of my file is large. I saw your document that is using readContent. I used WinRAR to archive the zip

[EunChae1110]

Here is any extraction method in libzippp?

[Jcdoliner]

Might be an old issue but if anybody still has trouble with this:

I had the same issue as you. you should put the mode of your ofstream to std::ios::binary. It can be something like this:
std::ofstream desFile((filename),std::ios::binary);
This causes the output file stream to open in binary mode thus appending the correct character sequence.