Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

World names can collide with GLSL keywords #7

Open
tangent-vector opened this issue Jun 3, 2016 · 0 comments
Open

World names can collide with GLSL keywords #7

tangent-vector opened this issue Jun 3, 2016 · 0 comments

Comments

@tangent-vector
Copy link
Collaborator

I tried to name my frament world fragment and so forth, but when I try to name a world uniform, the Spire front-end generates GLSL code with a declaration like:

uniform uniform { ... }

which is obviously not valid GLSL. I haven't done any digging into whether using GLSL keywords for other sorts of names causes problems, but it would be nice if the output GLSL went to some effort to "mangle" names to avoid collision with GLSL keywords.

A simple strategy would be to prefix every name with something like SPIRE_*, but this would result in less immediately readable GLSL output.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant