Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Money into Module + Struct for internal impl. #4

Open
Sija opened this issue Feb 13, 2018 · 0 comments
Open

Refactor Money into Module + Struct for internal impl. #4

Sija opened this issue Feb 13, 2018 · 0 comments
Labels
enhancement help wanted

Comments

@Sija
Copy link
Member

Sija commented Feb 13, 2018

👍

  • Changing Money into a Module will make it include-able
  • Changing Money from Class to Struct will take the pressure off the GC
  • Money instances are already immutable

👎

  • Money instances will have to compared against internal impl.: money.is_a?(Money::Base)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Sija