Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problem: sendToCosmos can be called with non erc20 tokens #72

Open
yihuang opened this issue Sep 14, 2021 · 1 comment
Open

Problem: sendToCosmos can be called with non erc20 tokens #72

yihuang opened this issue Sep 14, 2021 · 1 comment
Labels
gravity bridge This issue or pull request is related to the Gravity Bridge functionality help wanted Extra attention is needed

Comments

@yihuang
Copy link
Collaborator

yihuang commented Sep 14, 2021

https://github.com/FrancoCRO/eth-gravity/blob/feature/erc721-to-gravity/test/Gravity.test.js#L19

Franco did the test that one can call sendToCosmos with an erc721 token, because erc721 and erc20 using the same method signatures, but gravity bridge will treat it as a fungible token and cause a disastrous result, user could lose their nfts.
@yihuang yihuang mentioned this issue Sep 15, 2021
Open
@yihuang
Copy link
Collaborator Author

yihuang commented Sep 15, 2021 •
edited
Loading

yihuang@34bff59
This is one solution I came up with, not sure if there is a more generic solution.

@tomtau tomtau added gravity bridge This issue or pull request is related to the Gravity Bridge functionality help wanted Extra attention is needed labels Oct 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
gravity bridge This issue or pull request is related to the Gravity Bridge functionality help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yihuang @tomtau