Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problem: internal EVM call don't fail if the method is not implemented #318

Open
yihuang opened this issue Jan 26, 2022 · 0 comments
Open

Problem: internal EVM call don't fail if the method is not implemented #318

yihuang opened this issue Jan 26, 2022 · 0 comments

Comments

@yihuang
Copy link
Collaborator

yihuang commented Jan 26, 2022 •
edited
Loading

which causes a serious issue in token mapping, if the mapped contract lacks the mint_by_cronos_module method, then when converting tokens, the native tokens will disappear, and there are no equivalent crc20 tokens minted.
we better check the Transfer event in the returned receipt logs.
@yihuang yihuang changed the title Problem: internal EVM call don't fail if method is not implemented Problem: internal EVM call don't fail if the method is not implemented Jan 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@yihuang