Improve support for linux/arm64/v8 on most Ubuntu-based images (part 2)
#1630
Conversation
| ENV CROSS_SYSROOT=/usr/aarch64-linux-gnu | ||
|
|
||
| COPY apt-cross-essential.sh / | ||
| RUN TARGET_ARCH=arm64 TARGET_TRIPLE=aarch64-linux-gnu /apt-cross-essential.sh |
There was a problem hiding this comment.
Hmm, looking at this again makes me suspicious of this approach, it makes it harder to debug with a glance whats extra in the image. Id prefer it if the script was removed or if the wanted packages were explicitly passed as arguments
There was a problem hiding this comment.
reverted these changes
There was a problem hiding this comment.
I think there will be some problems with this, due to what was mentioned here
|
looks good, can you rebase the changes such that there's no merge commit? |
|
/ci try |
This comment has been minimized.
This comment has been minimized.
|
need to test with --platform arm64/v8 also |
|
Hey thanks for doing this! Things have been crazy where I live so I've been short on time ❤️ |
Do you want me to change |
garasubo
force-pushed
the
more-arm64-docker-builds
branch
from
cc80331 to
9b8b766
Compare
garasubo
force-pushed
the
more-arm64-docker-builds
branch
from
9b8b766 to
a581024
Compare
|
rebased the branch to remove merge commit from this PR. |
If you think you can do it in this pr, feel free to do so. Take care of the comments i left in the previous pr about some ways to make it work. |
|
@Emilgardis I caught up the discussion on the previous PR, and tried to change to enable to publish arm64 images, but it was harder than I expected. So, I'd like to merge this PR first, and then submit another PR. Could you review my change again? |
There was a problem hiding this comment.
This file is not used anymore, i think however it would be worth to incorporate the command checking it does since the previous pr mentioned it was needed to avoid issues with gfortran
There was a problem hiding this comment.
I'm not sure what kind of issues with gfortran the previous pr were referring to. But it looks all Dockerfiles have apt install gfortran-${TARGET_TRIPLE}. Is there anything else that should be done? Otherwise, I'll just remove this file from the pr.
|
going to merge this, still some work left that is needed, but we'll work on that |
Emilgardis
changed the title
linux/arm64/v8 for most Ubuntu-based images (part 2)linux/arm64/v8 on most Ubuntu-based images (part 2)
Emilgardis
added
A-aarch64-host
This is a follow-up to #1597. Docker images for Arm64-based PCs has been added.