-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support filter params in HTTP GET request content #767
Comments
JochenReinhardt
added a commit
to JochenReinhardt/crnk-framework
that referenced
this issue
Jul 20, 2020
Opened a feature branch in a forked repository. |
JochenReinhardt
added a commit
to JochenReinhardt/crnk-framework
that referenced
this issue
Jul 21, 2020
…r for filter in body
JochenReinhardt
added a commit
to JochenReinhardt/crnk-framework
that referenced
this issue
Jul 21, 2020
…HttpGetWithBody
Opened pull request: #771 |
JochenReinhardt
added a commit
to JochenReinhardt/crnk-framework
that referenced
this issue
Jul 22, 2020
JochenReinhardt
added a commit
to JochenReinhardt/crnk-framework
that referenced
this issue
Jul 24, 2020
JochenReinhardt
added a commit
to JochenReinhardt/crnk-framework
that referenced
this issue
Aug 4, 2020
…c - replaced with AND
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In order to avoid URL length issues with complex filters, I would like to add an option to pass the filter as HTTP GET request content.
This should be done at least for nested filters (http://www.crnk.io/releases/stable/documentation/#_nested_filtering) as there is a single filter query parameter that actually contains a JSON-formatted object.
I would not mind passing any other filters also in the request content for consistency reasons. As far as I understand, it should be feasible as filters in the URL e.g.
GET /tasks?filter[name]=Super task
can be written as JSON-object, too:{ "name": "Super task" }
.As this is non-standard-behavior, I would like to implement a configuration option that is by default turned off. Something like
crnk.config.resource.request.filterCriteriaInHttpContent
inCrnkProperties
.I am going to have a look at this myself and hopefully will come up with a pull request, soon.
Any comments, help or objections welcome.
The text was updated successfully, but these errors were encountered: