Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] No easy way to change (or remove) pull-secret #2572

Open
gbraad opened this issue Jul 13, 2021 · 4 comments · May be fixed by crc-org/docs#15
Open

[BUG] No easy way to change (or remove) pull-secret #2572

gbraad opened this issue Jul 13, 2021 · 4 comments · May be fixed by crc-org/docs#15
Assignees
@rohanKanojia
Labels
kind/bug Something isn't working os/macos os/windows priority/major status/pinned Prevents the stale bot from closing the issue
Milestone
Backlog

Comments

@gbraad
Copy link
Contributor

gbraad commented Jul 13, 2021 •
edited
Loading

When the pull-secret is stored in secure storage, it is difficult to change this to another one. This can happen when the pull-secret is revoked or has to be changed. However when the pull-secret API is used to store a copy&pasted pull-secret, it is not possible to use crc config to reset or unset it. Only crc cleanup allows for the removal, but this command has too many side-effects.
@gbraad
Copy link
Contributor Author

gbraad commented Jul 13, 2021 •
edited
Loading

A possible solution would be to use crc config set/unset pull-secret as an abstracted (intercepted) config option to deal with the pull secret API.

however, when crc config view is used, only ******** is shown to indicate a value has been given.

@gbraad gbraad changed the title [BUG] No easy way to change pull-secret [BUG] No easy way to change (or remove) pull-secret Jul 20, 2021
@anjannath
Copy link
Member

anjannath commented Jul 21, 2021 •
edited
Loading

Should we instead document how the user can remove it by using the os provided tools (keychain in macos and credential manager on windows)? my concern is having both pull-secret and pull-secret-file as config options would be confusing.

@ben-alkov
Copy link

Should we ... document how the user can remove it by using the os provided tools...?

Yes, please, including Linux.

@stale
Copy link

stale bot commented Sep 21, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the status/stale Issue went stale; did not receive attention or no reply from the OP label Sep 21, 2021
@cfergeau cfergeau added the status/pinned Prevents the stale bot from closing the issue label Sep 21, 2021
@stale stale bot removed the status/stale Issue went stale; did not receive attention or no reply from the OP label Sep 21, 2021
@anjannath anjannath added this to the Backlog milestone Mar 12, 2024
@rohanKanojia rohanKanojia self-assigned this Jan 3, 2025
This was referenced Jan 6, 2025
Closed
Open
@rohanKanojia rohanKanojia moved this to Ready for review in Project planning: crc Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rohanKanojia rohanKanojia

Labels
kind/bug Something isn't working os/macos os/windows priority/major status/pinned Prevents the stale bot from closing the issue
Projects
Project planning: crc
Status: Ready for review
Milestone
Backlog
Development

Successfully merging a pull request may close this issue.

doc : Add steps to remove CRC pull secret from OS provided tools (#2572) rohankanojia-forks/docs
5 participants
@gbraad @cfergeau @anjannath @rohanKanojia @ben-alkov