Allow to select preflight checks to run for setup

[anjannath]

Right now when crc setup command is run we run all the preflight checks, this issue is for introducing a flag for crc setup [crc setup --checks bundle-extract,add-user-to-hyperv]? with which we can select the specific preflight checks we want to run.

This will be used from the tray for extracting the bundle see crc-org/tray-windows#118

edit: The generic issue is: #2469 , and the MSI installer also needs something like this.

[cfergeau]

I'm not in favour of exposing this in the command line UI. If it's for tray use, could this be something added only to the HTTP API?

[anjannath]

I was thinking to also use this in the msi (run crc setup --check add-user-to-hyperv-group in a custom action) for adding users to groups, that'd solve the issues on localized versions of windows.

[gbraad]

This has been one of the proposed solution to deal with preflight fixes that could be shared with the MSI. There was already a generic issue for this; this is the breakdown issue. The functionality is supposed to be hidden/only used internally.

[cfergeau]

This will be used from the tray for extracting the bundle see crc-org/tray-windows#118

Can this be edited to also mention the MSI, and link back to the generic issue?

[praveenkumar]

As we discussed on internal channel, we should only include the preflight checks for windows which are needed for installer and remove other checks (which is there because of flat binary) we should be remove the creation of those binaries for windows like we did for Mac.

[gbraad]

The generic issue is: #2469

We can not remove ALL (just OS-specific) pre-flights, as Linux would still rely on them.

[anjannath]

Also another thing is if we remove even the OS specific checks (consider the windows checks) these won't be ran even during a crc start or start from the tray. Which actually catches issues with the host environment early on

[gbraad]

Yep...

... I believe only binary checks should be removed, as we can assume the installer takes care of this.

[cfergeau]

I think the suggestion was, on Windows and only on Windows, to remove all checks which are specific to the fat binary (which is being phased out), and which are redundant with what the installer is already doing. The follow-up question being if after doing this cleanup, we still need a way to run a subset of preflights or not, or if the tests which remain are the ones we'd like to run. And it seems the answer is that yes, there are some tests to remove, but no, there will still be moer preflights needed than the subset we want to run.

[gbraad]

We have to be careful about `crc cleanup`. This command should not exist. We kind of added this to allow repeatable scenarios for QE... maybe deprecate/remove and come up with cleaning instructions for the tests?

…

On Wed, Aug 4, 2021 at 4:10 PM Christophe Fergeau ***@***.***> wrote: I think the suggestion was, on Windows and only on Windows, to remove all checks which are specific to the fat binary (which is being phased out), and which are redundant with what the installer is already doing. The follow-up question being if after doing this cleanup, we still need a way to run a subset of preflights or not, or if the tests which remain are the ones we'd like to run. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#2622 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAAOZT5CPKURAYWG4SCGFDT3DYWFANCNFSM5BOCRD4A> .

-- Gerard Braad | http://gbraad.nl STEM is the source, but BUILD is how you develop! [ Better Understanding Involves Learning and Doing ]

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[anjannath]

This is not needed anymore, we only have preflight checks that are needed for the platform, and for showing progress of setup to users we'll focus on #2935