Extend the E2E tests to be run on windows #430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danivilla9
force-pushed
the
382-automate-e2e-tests-windows
branch
2 times, most recently
from
c8552f9 to
4bde536
Compare
danivilla9
force-pushed
the
382-automate-e2e-tests-windows
branch
from
a9eb7fb to
10c3944
Compare
odockal
requested changes
Dec 16, 2024
danivilla9
force-pushed
the
382-automate-e2e-tests-windows
branch
2 times, most recently
from
d3dc56a to
b15e700
Compare
odockal
reviewed
Dec 19, 2024
danivilla9
force-pushed
the
382-automate-e2e-tests-windows
branch
from
b15e700 to
0018721
Compare
danivilla9
force-pushed
the
382-automate-e2e-tests-windows
branch
2 times, most recently
from
6061265 to
32a2535
Compare
odockal
requested changes
Jan 8, 2025
.github/workflows/pr-check.yaml
Outdated
| Copy-Item -Path "./icon.png" -Destination ".\tests\playwright\output\crc-tests-pd\plugins\crcextension" -Force | ||
| Copy-Item -Path "./README.md" -Destination ".\tests\playwright\output\crc-tests-pd\plugins\crcextension" -Force | ||
| Copy-Item -Path "./dist" -Destination ".\tests\playwright\output\crc-tests-pd\plugins\crcextension" -Recurse -Force | ||
| 'package.json', 'LICENSE', 'icon.png', 'README.md', 'dist' | % { cp $_ ./tests/playwright/output/crc-tests-pd/plugins/crcextension -Recurse -Force } |
There was a problem hiding this comment.
you would need to use -r in cp since it is a directory
Signed-off-by: Daniel Villanueva <[email protected]>
danivilla9
force-pushed
the
382-automate-e2e-tests-windows
branch
from
42977a4 to
f4fb1ab
Compare
odockal
approved these changes
Jan 9, 2025
There was a problem hiding this comment.
@danivilla9 as talked about in chat, cp should work in powershell with these flags (https://learn.microsoft.com/en-us/powershell/module/microsoft.powershell.management/copy-item?view=powershell-7.4), so good to go.
Good work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #382