Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mac80211 doesn't report NL80211_FEATURE_SK_TX_STATUS #10

Open
silverjam opened this issue Apr 25, 2014 · 1 comment
Open

mac80211 doesn't report NL80211_FEATURE_SK_TX_STATUS #10

silverjam opened this issue Apr 25, 2014 · 1 comment
Labels
bug

Comments

@silverjam
Copy link
Member

Issue by twpedersen from Monday May 13, 2013 at 23:27 GMT
Originally opened as cozybit/wpa_s_mesh_android#1

we currently have this hack

--- a/src/drivers/driver_nl80211.c
+++ b/src/drivers/driver_nl80211.c
@@ -2710,6 +2710,8 @@ broken_combination:
 
                if (flags & NL80211_FEATURE_SK_TX_STATUS)
                        info->data_tx_status = 1;
+               else
+                       info->data_tx_status = 1;

To force wpa_supplicant to use the nl80211 frame injection API, as opposed to needing a monitor interface. For some reason NL80211_FEATURE_SK_TX_STATUS is not set on android (no issues on pc using the same compat-drivers).
@silverjam
Copy link
Member Author

Comment by silverjam from Tuesday Apr 22, 2014 at 21:32 GMT

This might be a bug with Android's libnl implementation? So, perhaps this isn't a wpa_s bug, and we need to do more investigation to isolate the root cause.

bcopeland added a commit that referenced this issue May 6, 2014
@bcopeland
driver: add new NL80211 cmds to support mesh ifaces
4ae3c3d 
- Create mesh_join and mesh_leave actions to kernel.
- Handle new_peer_candidate events from kernel.
- Register to receive necessary frames.
- Add plink_action_field and mesh_power_mode to hostapd_sta_add_params

Signed-off-by: Javier Lopez <[email protected]>
Signed-off-by: Javier Cardona <[email protected]>
Signed-off-by: Jason Mobarak <[email protected]>

Signed-hostap: Bob Copeland <[email protected]>

---

v2: - Split out the widing of the drv_flags / flags into separate patch.
    - Squash with "Clarify comment on TODO" cozybit/wpa_s_mesh_android@9543020
    - Squash with "Add plink_action_field and mesh_power_mode to hostapd_sta_add_params" cozybit/wpa_s_mesh_android@89d29f6
    - Squash with "Clarify comment (issue #10)" cozybit/wpa_s_mesh_android@21734bc
    - Squash with "closes #12" cozybit/wpa_s_mesh_android@4d7209e
    - Squash with "Closes #16" cozybit/wpa_s_mesh_android@fa05631
    - Squash with "No default mesh frequency. Closes #18" cozybit/wpa_s_mesh_android@03f80b9
    - Squash with "Closes #19" cozybit/wpa_s_mesh_android@3cf9b4c
    - Squash with "Set mesh authentication protocol id in mesh config" cozybit/wpa_s_mesh_android@caaf6ee
    - Squash with "PLINK_CLOSE can have only MESHID and MPM IEs" cozybit/wpa_s_mesh_android@6c4fd81

v3: Remove workaround for NL80211_FEATURE_SK_TX_STATUS
v4: No changes
v5: Removed extraneous else for NL80211_FEATURE_SK_TX_STATUS change
v6: Updated email addresses, added signed-hostap for Bob
bcopeland added a commit that referenced this issue May 7, 2014
@bcopeland
driver: add new NL80211 cmds to support mesh ifaces
89a6d39 
- Create mesh_join and mesh_leave actions to kernel.
- Handle new_peer_candidate events from kernel.
- Register to receive necessary frames.
- Add plink_action_field and mesh_power_mode to hostapd_sta_add_params

Signed-off-by: Javier Lopez <[email protected]>
Signed-off-by: Javier Cardona <[email protected]>
Signed-off-by: Jason Mobarak <[email protected]>
Signed-hostap: Bob Copeland <[email protected]>

---

v2: - Split out the widing of the drv_flags / flags into separate patch.
    - Squash with "Clarify comment on TODO" cozybit/wpa_s_mesh_android@9543020
    - Squash with "Add plink_action_field and mesh_power_mode to hostapd_sta_add_params" cozybit/wpa_s_mesh_android@89d29f6
    - Squash with "Clarify comment (issue #10)" cozybit/wpa_s_mesh_android@21734bc
    - Squash with "closes #12" cozybit/wpa_s_mesh_android@4d7209e
    - Squash with "Closes #16" cozybit/wpa_s_mesh_android@fa05631
    - Squash with "No default mesh frequency. Closes #18" cozybit/wpa_s_mesh_android@03f80b9
    - Squash with "Closes #19" cozybit/wpa_s_mesh_android@3cf9b4c
    - Squash with "Set mesh authentication protocol id in mesh config" cozybit/wpa_s_mesh_android@caaf6ee
    - Squash with "PLINK_CLOSE can have only MESHID and MPM IEs" cozybit/wpa_s_mesh_android@6c4fd81

v3: Remove workaround for NL80211_FEATURE_SK_TX_STATUS
v4: No changes
v5: Removed extraneous else for NL80211_FEATURE_SK_TX_STATUS change
v6: Updated email addresses, added signed-hostap for Bob
v7: remove blank lines
bcopeland added a commit that referenced this issue May 9, 2014
@bcopeland
driver: add new NL80211 cmds to support mesh ifaces
19e97d4 
- Create mesh_join and mesh_leave actions to kernel.
- Handle new_peer_candidate events from kernel.
- Register to receive necessary frames.
- Add plink_action_field and mesh_power_mode to hostapd_sta_add_params

Signed-off-by: Javier Lopez <[email protected]>
Signed-off-by: Javier Cardona <[email protected]>
Signed-off-by: Jason Mobarak <[email protected]>
Signed-hostap: Bob Copeland <[email protected]>

---

v2: - Split out the widing of the drv_flags / flags into separate patch.
    - Squash with "Clarify comment on TODO" cozybit/wpa_s_mesh_android@9543020
    - Squash with "Add plink_action_field and mesh_power_mode to hostapd_sta_add_params" cozybit/wpa_s_mesh_android@89d29f6
    - Squash with "Clarify comment (issue #10)" cozybit/wpa_s_mesh_android@21734bc
    - Squash with "closes #12" cozybit/wpa_s_mesh_android@4d7209e
    - Squash with "Closes #16" cozybit/wpa_s_mesh_android@fa05631
    - Squash with "No default mesh frequency. Closes #18" cozybit/wpa_s_mesh_android@03f80b9
    - Squash with "Closes #19" cozybit/wpa_s_mesh_android@3cf9b4c
    - Squash with "Set mesh authentication protocol id in mesh config" cozybit/wpa_s_mesh_android@caaf6ee
    - Squash with "PLINK_CLOSE can have only MESHID and MPM IEs" cozybit/wpa_s_mesh_android@6c4fd81

v3: Remove workaround for NL80211_FEATURE_SK_TX_STATUS
v4: No changes
v5: Removed extraneous else for NL80211_FEATURE_SK_TX_STATUS change
v6: Updated email addresses, added signed-hostap for Bob
v7: remove blank lines
bcopeland added a commit that referenced this issue May 30, 2014
@bcopeland
driver: add new NL80211 cmds to support mesh ifaces
b01e069 
- To support mesh mode, use u64 to fit all necessary driver flags.
- Create mesh_join and mesh_leave actions to kernel.
- Handle new_peer_candidate events from kernel.
- Register to receive necessary frames.
- Add plink_action_field and mesh_power_mode to hostapd_sta_add_params

Signed-off-by: Javier Lopez <[email protected]>
Signed-off-by: Javier Cardona <[email protected]>
Signed-off-by: Jason Mobarak <[email protected]>
Signed-hostap: Bob Copeland <[email protected]>

---

v2: - Split out the widing of the drv_flags / flags into separate patch.
    - Squash with "Clarify comment on TODO" cozybit/wpa_s_mesh_android@9543020
    - Squash with "Add plink_action_field and mesh_power_mode to hostapd_sta_add_params" cozybit/wpa_s_mesh_android@89d29f6
    - Squash with "Clarify comment (issue #10)" cozybit/wpa_s_mesh_android@21734bc
    - Squash with "closes #12" cozybit/wpa_s_mesh_android@4d7209e
    - Squash with "Closes #16" cozybit/wpa_s_mesh_android@fa05631
    - Squash with "No default mesh frequency. Closes #18" cozybit/wpa_s_mesh_android@03f80b9
    - Squash with "Closes #19" cozybit/wpa_s_mesh_android@3cf9b4c
    - Squash with "Set mesh authentication protocol id in mesh config" cozybit/wpa_s_mesh_android@caaf6ee
    - Squash with "PLINK_CLOSE can have only MESHID and MPM IEs" cozybit/wpa_s_mesh_android@6c4fd81

v3: Remove workaround for NL80211_FEATURE_SK_TX_STATUS
v4: No changes
v5: Removed extraneous else for NL80211_FEATURE_SK_TX_STATUS change
v6: Updated email addresses, added signed-hostap for Bob
v7: remove blank lines
v8: add u64 driver flags
bcopeland added a commit that referenced this issue Jun 30, 2014
@bcopeland
driver: add new NL80211 cmds to support mesh ifaces
f5dfaf1 
- To support mesh mode, use u64 to fit all necessary driver flags.
- Create mesh_join and mesh_leave actions to kernel.
- Handle new_peer_candidate events from kernel.
- Register to receive necessary frames.
- Add plink_action_field and mesh_power_mode to hostapd_sta_add_params

Signed-off-by: Javier Lopez <[email protected]>
Signed-off-by: Javier Cardona <[email protected]>
Signed-off-by: Jason Mobarak <[email protected]>
Signed-hostap: Bob Copeland <[email protected]>

---

v2: - Split out the widing of the drv_flags / flags into separate patch.
    - Squash with "Clarify comment on TODO" cozybit/wpa_s_mesh_android@9543020
    - Squash with "Add plink_action_field and mesh_power_mode to hostapd_sta_add_params" cozybit/wpa_s_mesh_android@89d29f6
    - Squash with "Clarify comment (issue #10)" cozybit/wpa_s_mesh_android@21734bc
    - Squash with "closes #12" cozybit/wpa_s_mesh_android@4d7209e
    - Squash with "Closes #16" cozybit/wpa_s_mesh_android@fa05631
    - Squash with "No default mesh frequency. Closes #18" cozybit/wpa_s_mesh_android@03f80b9
    - Squash with "Closes #19" cozybit/wpa_s_mesh_android@3cf9b4c
    - Squash with "Set mesh authentication protocol id in mesh config" cozybit/wpa_s_mesh_android@caaf6ee
    - Squash with "PLINK_CLOSE can have only MESHID and MPM IEs" cozybit/wpa_s_mesh_android@6c4fd81

v3: Remove workaround for NL80211_FEATURE_SK_TX_STATUS
v4: No changes
v5: Removed extraneous else for NL80211_FEATURE_SK_TX_STATUS change
v6: Updated email addresses, added signed-hostap for Bob
v7: remove blank lines
v8: add u64 driver flags
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@silverjam