ci: Stringify automated registration errors #2340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taratatach
force-pushed
the
ci/format-automated-registration-errors-for-logging
branch
from
1d03418 to
60fcf1d
Compare
Base automatically changed from
fix/chokidar-handles-deletion-and-move-after-complete-move
to
master
August 2, 2024 16:01
taratatach
force-pushed
the
ci/format-automated-registration-errors-for-logging
branch
from
60fcf1d to
884398e
Compare
taratatach
force-pushed
the
ci/format-automated-registration-errors-for-logging
branch
from
884398e to
7da5f2f
Compare
When `cozy-stack` returns an error response to an OAuth authorization request, we throw a Javascript error with the response body. However, when the body is a JSON object, we only get its type in the error message rather than the content itself. By stringifying the body, we make sure its content will be included in the error message and thus displayed in the logs or console.
taratatach
force-pushed
the
ci/format-automated-registration-errors-for-logging
branch
from
7da5f2f to
22b5458
Compare
taratatach
deleted the
ci/format-automated-registration-errors-for-logging
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
cozy-stackreturns an error response to an OAuth authorizationrequest, we throw a Javascript error with the response body.
However, when the body is a JSON object, we only get its type in the
error message rather than the content itself.
By stringifying the body, we make sure its content will be included in
the error message and thus displayed in the logs or console.
Please make sure the following boxes are checked: