Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typescript support #95

Open
hronchetti opened this issue Dec 14, 2021 · 5 comments
Open

Typescript support #95

hronchetti opened this issue Dec 14, 2021 · 5 comments
Labels
enhancement New feature or request

Comments

@hronchetti
Copy link

Hey! Loving this simple package but I'm using TypeScript and the standard methods of:

npm i --save-dev @types/react-json-to-csv
yarn add -D @types/react-json-to-csv

Return 'Not found'. Are there any plans to add a TypeScript declaration file?

@coston coston added the enhancement New feature or request label Dec 14, 2021
@coston
Copy link
Owner

coston commented Dec 14, 2021

Hey @hronchetti, thanks for creating this issue. Yes, that's easily doable. Additionally, I plan to switch to building this package with typescript. This enhancement is something that I'll pickup when time permits, unless a community member would like to adopt the task first.

@nui-tech
Copy link

nui-tech commented Jun 25, 2022

Hey guys,
I've created a pull request for the type definition for this package.
If you guys have some time, it would be good to have you guys review the pull request and potentially approve it?
Cheers.

@nui-tech
Copy link

Hey guys,
The type is up on the npm registry https://www.npmjs.com/package/@types/react-json-to-csv
npm i --save-dev @types/react-json-to-csv

@coston
Copy link
Owner

coston commented Jun 29, 2022

Very nice, @nui-tech! Thank you for helping to support this project. 🎉

@coston
Copy link
Owner

coston commented Jun 29, 2022

I've added a typescript documentation to the docs.

📌 There is still opportunity to rewrite this package in TS, should someone want a project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants