Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Epic: Restore Gaian Leadership #3510

Closed
faddat opened this issue Jan 30, 2025 · 3 comments
Closed

Epic: Restore Gaian Leadership #3510

faddat opened this issue Jan 30, 2025 · 3 comments

Comments

@faddat
Copy link
Contributor

faddat commented Jan 30, 2025

Gaian Ascension

I noticed that in

We should get tokenfactory into the SDK.

We should not use a cgo virtual machine:

Code that the hub runs, ought to be cosmos-org code, and ought to be in the SDK, and get honed and standardized. Wasmvm is really the only thing stopping that, because of the ffi bits. Still, there are significant challenges in the reimplementation of wasmvm to use wazero.

Is most likely occuring because of this.

We should have contracts

Like many I'm of the opinion that Cosmwasm is a tremendous asset to Cosmos. Just, the virtual machine is a big downside.

Depinject

I think that the hub should use depinject, or depinject should be taken out of the sdk's developer flow

SDK upgrades

Gaia should be one of the first chains adopting new SDK releases. Its combination of software will allow it to naturally drive the refinement of a clear stack:

  • cometbft
  • cosmos-sdk
  • cosmwasm
  • IBC

We should use GitHub to communicate

It has long been an issue that things are poorly communicated due to an over-reliance on various internal slacks. While of course there's a place for that, decisions and plans should get to Github for wider discussion.

We should have a unified stack

The hub now has all of the common cosmos dependencies, because of the recent addition of cosmwasm. So, the hub spans

  • cometbft
  • cosmos-sdk
  • cosmwasm
  • IBC

....and is therefore in a place to lead.

@Eric-Warehime
Copy link
Contributor

Hey, thanks for opening this issue.
Certain of these things seem like they would be best in other repos.

  • Upstreaming the tokenfactory module to the sdk or wasmd probably belongs in those repos.
  • The cgo removal from cosmwasm is very interesting, but is best handled in that repo as well.

We're currently undergoing an audit of cosmwasm so hopefully any memory leaks in it are identified and fixed there. If you have more detailed information on the cause of #3417 I'd be happy to look into that.

Depinject integration is a possibility, but it's pretty painful to have some modules use it and others not. Until ibc has adopted it, I probably wouldn't consider using it on gaia. cosmos/ibc-go#3560

We're working to get the LSM sorted out in a way that moves gaia off of a fork. We want the hub to be using the latest and greatest in cosmos technology and versions, so we're prioritizing anything which will speed up upgrades and make it easy for us to adopt new features in the future.

I'm going to close this for now in favor of tracking most of this stuff separately, but thanks for raising this!

@github-project-automation github-project-automation bot moved this from 🩹 F1: Triage to 👍 F4: Assessment in Cosmos Hub Feb 6, 2025
@faddat
Copy link
Contributor Author

faddat commented Feb 7, 2025

they're all the same thing more or less.

@faddat
Copy link
Contributor Author

faddat commented Feb 7, 2025

There's an important question in here. Does depinject work or no?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 👍 F4: Assessment
Development

No branches or pull requests

2 participants