Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade mainnet forking tool to support provider endblocker changes #3372

Closed
Tracked by #3353
MSalopek opened this issue Oct 3, 2024 · 1 comment · Fixed by #3375
Closed
Tracked by #3353

upgrade mainnet forking tool to support provider endblocker changes #3372

MSalopek opened this issue Oct 3, 2024 · 1 comment · Fixed by #3375
Assignees
Labels
scope: testing Code review, testing, making sure the code is following the specification. scope: testnet

Comments

@MSalopek
Copy link
Contributor

MSalopek commented Oct 3, 2024

Tool stopped working on versions >= v20.0.0.

 gaiad testnet unsafe-start-local-validator  \
--validator-operator="cosmosvaloper1pazy2th7lz38pjlxgt6d72p82trkdlrqnh3ja7"  \
--validator-pubkey="x1T1PtozNbSZGZajD2S6/Lp0ObYvhzRcwxFDb2P6L+Y=" \
--validator-privkey="toUbarT3MwRqgakYVka4PNQKzIjTs3Ql8tqXRozWBuzHVPU+2jM1tJkZlqMPZLr8unQ5ti+HNFzDEUNvY/ov5g=="  \
--accounts-to-fund="cosmos1pazy2th7lz38pjlxgt6d72p82trkdlrqkr983d"

Seems related to cometbft v0.38.11 and higher versions.

The tool encounters a consensus failure with node snapshots:

2:52PM INF Replay: Vote blockID=C80F67CDC3EFDB6E3496605908EFBDEA0A73E58315E9B34A3491C3383702D8F4:1:5ED0B863FBFA extSigLen=0 extensionLen=0 height=22453073 module=consensus peer=7314c477c9d7fea4e2ebf51581f2324971260494 round=0 type=SIGNED_MSG_TYPE_PRECOMMIT
2:52PM INF failed attempting to add vote err="cannot find validator 151 in valSet of size 1: invalid validator index" module=consensus
2:52PM ERR failed to process message err="error adding vote" height=22453074 module=consensus msg_type=*consensus.VoteMessage peer=7314c477c9d7fea4e2ebf51581f2324971260494 round=0

2:52PM ERR CONSENSUS FAILURE!!! err="failed to apply block; error commit failed for application: changing validator set: failed to find validator 000001E443FD237E4B616E2FA69DF4EE3D49A94F to remove"
@github-project-automation github-project-automation bot moved this to 🩹 F1: Triage in Cosmos Hub Oct 3, 2024
@MSalopek MSalopek added scope: testing Code review, testing, making sure the code is following the specification. scope: testnet labels Oct 3, 2024
@MSalopek MSalopek moved this from 🩹 F1: Triage to 📥 F2: Todo in Cosmos Hub Oct 3, 2024
@stana-miric stana-miric changed the title upgrade mainnet forking tool to support comet > v0.38.11 upgrade mainnet forking tool to support provider endblocker changes Oct 4, 2024
@stana-miric
Copy link
Contributor

The problem was in provider's store, since we didn't clear the data related to the old validator set. Fixed with #3375

@github-project-automation github-project-automation bot moved this from 📥 F2: Todo to 👍 F4: Assessment in Cosmos Hub Oct 4, 2024
@mpoke mpoke moved this from 👍 F4: Assessment to ✅ Done in Cosmos Hub Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: testing Code review, testing, making sure the code is following the specification. scope: testnet
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

2 participants