From 9eefa08ce4d20a9e5afb850744831642a2a428cb Mon Sep 17 00:00:00 2001
From: Liam Young <liam.young@canonical.com>
Date: Thu, 28 May 2020 10:57:29 +0000
Subject: [PATCH] Refactor Designate tests so API tests can be called

Refactor Designate tests so that the api tests can be called
without running pause/resume tests. This is useful in the mojo
replacement functional tests.
---
 zaza/openstack/charm_tests/designate/tests.py | 68 +++++++++++--------
 1 file changed, 39 insertions(+), 29 deletions(-)

diff --git a/zaza/openstack/charm_tests/designate/tests.py b/zaza/openstack/charm_tests/designate/tests.py
index f8a32db26..5583f0bdb 100644
--- a/zaza/openstack/charm_tests/designate/tests.py
+++ b/zaza/openstack/charm_tests/designate/tests.py
@@ -83,8 +83,8 @@ def setUpClass(cls, application_name=None, model_alias=None):
             cls.server_delete = cls.designate.servers.delete
 
 
-class DesignateTests(BaseDesignateTest):
-    """Designate charm restart and pause tests."""
+class DesignateAPITests(BaseDesignateTest):
+    """Tests interact with designate api."""
 
     TEST_DOMAIN = 'amuletexample.com.'
     TEST_NS1_RECORD = 'ns1.{}'.format(TEST_DOMAIN)
@@ -92,33 +92,6 @@ class DesignateTests(BaseDesignateTest):
     TEST_WWW_RECORD = "www.{}".format(TEST_DOMAIN)
     TEST_RECORD = {TEST_WWW_RECORD: '10.0.0.23'}
 
-    def test_900_restart_on_config_change(self):
-        """Checking restart happens on config change.
-
-        Change debug mode and assert that change propagates to the correct
-        file and that services are restarted as a result
-        """
-        # Services which are expected to restart upon config change,
-        # and corresponding config files affected by the change
-        conf_file = '/etc/designate/designate.conf'
-
-        # Make config change, check for service restarts
-        self.restart_on_changed_debug_oslo_config_file(
-            conf_file,
-            self.designate_svcs,
-        )
-
-    def test_910_pause_and_resume(self):
-        """Run pause and resume tests.
-
-        Pause service and check services are stopped then resume and check
-        they are started
-        """
-        with self.pause_resume(
-                self.designate_svcs,
-                pgrep_full=False):
-            logging.info("Testing pause resume")
-
     def _get_server_id(self, server_name=None, server_id=None):
         for srv in self.server_list():
             if isinstance(srv, dict):
@@ -245,3 +218,40 @@ def test_400_domain_creation(self):
         logging.debug('Tidy up delete test record')
         self._wait_on_domain_gone(domain_id)
         logging.debug('OK')
+
+
+class DesignateCharmTests(BaseDesignateTest):
+    """Designate charm restart and pause tests."""
+
+    def test_900_restart_on_config_change(self):
+        """Checking restart happens on config change.
+
+        Change debug mode and assert that change propagates to the correct
+        file and that services are restarted as a result
+        """
+        # Services which are expected to restart upon config change,
+        # and corresponding config files affected by the change
+        conf_file = '/etc/designate/designate.conf'
+
+        # Make config change, check for service restarts
+        self.restart_on_changed_debug_oslo_config_file(
+            conf_file,
+            self.designate_svcs,
+        )
+
+    def test_910_pause_and_resume(self):
+        """Run pause and resume tests.
+
+        Pause service and check services are stopped then resume and check
+        they are started
+        """
+        with self.pause_resume(
+                self.designate_svcs,
+                pgrep_full=False):
+            logging.info("Testing pause resume")
+
+
+class DesignateTests(DesignateAPITests, DesignateCharmTests):
+    """Collection of all Designate test classes."""
+
+    pass