Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove limits from the coredns deployment default values.yaml #193

Open
FabioAntunes opened this issue Jan 21, 2025 · 1 comment
Open

Remove limits from the coredns deployment default values.yaml #193

FabioAntunes opened this issue Jan 21, 2025 · 1 comment

Comments

@FabioAntunes
Copy link

FabioAntunes commented Jan 21, 2025

Due to a bug in Helm there's no way for us to unset limits when using CoreDNS as sub chart.
helm/helm#12637

May I suggest we do this on the current values.yaml?

resources:
-  limits:
-    cpu: 100m
-    memory: 128Mi
  requests:
    cpu: 100m
    memory: 128Mi

With the current chart there's no way for us deploy CoreDNS without CPU limits

Happy to open a PR

@hagaibarel
Copy link
Collaborator

Hi,

While I generally agree that this is right, it is a breaking change that moves coredns from Guaranteed QoS to Best Effort which might have negative affects on deployments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants