From 8dda5ae1ae7694033782f6c4352d84e80c795ba2 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Manuel=20R=C3=BCger?= Date: Thu, 11 Feb 2021 15:29:52 +0100 Subject: [PATCH 1/6] Add AppVersion to the deployment labels MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Manuel Rüger Signed-off-by: ajayk --- stable/coredns/Chart.yaml | 2 +- stable/coredns/templates/deployment.yaml | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/stable/coredns/Chart.yaml b/stable/coredns/Chart.yaml index 90ad249..a0ef0e1 100644 --- a/stable/coredns/Chart.yaml +++ b/stable/coredns/Chart.yaml @@ -1,6 +1,6 @@ apiVersion: v2 name: coredns -version: 1.14.2 +version: 1.14.3 appVersion: 1.8.0 home: https://coredns.io icon: https://coredns.io/images/CoreDNS_Colour_Horizontal.png diff --git a/stable/coredns/templates/deployment.yaml b/stable/coredns/templates/deployment.yaml index 325660d..5dd2b35 100644 --- a/stable/coredns/templates/deployment.yaml +++ b/stable/coredns/templates/deployment.yaml @@ -12,6 +12,7 @@ metadata: kubernetes.io/name: "CoreDNS" {{- end }} app.kubernetes.io/name: {{ template "coredns.name" . }} + app.kubernetes.io/version: {{ .Chart.AppVersion | quote }} {{- if .Values.customLabels }} {{ toYaml .Values.customLabels | indent 4 }} {{- end }} From 929d87e174f9d0718ed5551a68e28ab5ed857e05 Mon Sep 17 00:00:00 2001 From: Michael Kriese Date: Fri, 26 Feb 2021 15:07:23 +0100 Subject: [PATCH 2/6] fix: add missing cluster role rules Signed-off-by: Michael Kriese Signed-off-by: ajayk --- stable/coredns/templates/clusterrole.yaml | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/stable/coredns/templates/clusterrole.yaml b/stable/coredns/templates/clusterrole.yaml index 029d13e..5434baa 100644 --- a/stable/coredns/templates/clusterrole.yaml +++ b/stable/coredns/templates/clusterrole.yaml @@ -24,6 +24,13 @@ rules: verbs: - list - watch +- apiGroups: + - discovery.k8s.io + resources: + - endpointslices + verbs: + - list + - watch {{- if .Values.rbac.pspEnable }} - apiGroups: - policy From 4478833c0d5ed9c1e79069d44857da19d45c352d Mon Sep 17 00:00:00 2001 From: Michael Kriese Date: Fri, 26 Feb 2021 15:10:55 +0100 Subject: [PATCH 3/6] chore: bump chart version Signed-off-by: Michael Kriese Signed-off-by: ajayk --- stable/coredns/Chart.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/stable/coredns/Chart.yaml b/stable/coredns/Chart.yaml index 90ad249..a0ef0e1 100644 --- a/stable/coredns/Chart.yaml +++ b/stable/coredns/Chart.yaml @@ -1,6 +1,6 @@ apiVersion: v2 name: coredns -version: 1.14.2 +version: 1.14.3 appVersion: 1.8.0 home: https://coredns.io icon: https://coredns.io/images/CoreDNS_Colour_Horizontal.png From d9b7e97ff2164b2d01b1ae2ec293f45a4f1a7cc7 Mon Sep 17 00:00:00 2001 From: ajayk Date: Tue, 2 Mar 2021 23:05:04 -0800 Subject: [PATCH 4/6] change readme to point to coredns helm repo and other doc fixes Signed-off-by: ajayk --- stable/coredns/README.md | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/stable/coredns/README.md b/stable/coredns/README.md index bf3a03a..ff41bef 100644 --- a/stable/coredns/README.md +++ b/stable/coredns/README.md @@ -5,7 +5,7 @@ # TL;DR; ```console -$ helm install --name coredns --namespace=kube-system stable/coredns +$ helm install coredns --namespace=kube-system coredns/coredns ``` ## Introduction @@ -25,7 +25,8 @@ This chart bootstraps a [CoreDNS](https://github.com/coredns/coredns) deployment The chart can be installed as follows: ```console -$ helm install --name coredns --namespace=kube-system stable/coredns +$ helm repo add coredns https://coredns.github.io/helm +$ helm install coredns --namespace=kube-system coredns/coredns ``` The command deploys CoreDNS on the Kubernetes cluster in the default configuration. The [configuration](#configuration) section lists various ways to override default configuration during deployment. @@ -34,7 +35,7 @@ The command deploys CoreDNS on the Kubernetes cluster in the default configurati ## Uninstalling the Chart -To uninstall/delete the `my-release` deployment: +To uninstall/delete the `coredns` deployment: ```console $ helm delete coredns @@ -47,7 +48,7 @@ The command removes all the Kubernetes components associated with the chart and | Parameter | Description | Default | |:----------------------------------------|:--------------------------------------------------------------------------------------|:------------------------------------------------------------| | `image.repository` | The image repository to pull from | coredns/coredns | -| `image.tag` | The image tag to pull from | `v1.7.1` | +| `image.tag` | The image tag to pull from | `1.8.0` | | `image.pullPolicy` | Image pull policy | IfNotPresent | | `replicaCount` | Number of replicas | 1 | | `resources.limits.cpu` | Container maximum CPU | `100m` | @@ -98,7 +99,7 @@ The command removes all the Kubernetes components associated with the chart and | `autoscaler.includeUnschedulableNodes` | Should the replicas scale based on the total number or only schedulable nodes | `false` | | `autoscaler.preventSinglePointFailure` | If true does not allow single points of failure to form | `true` | | `autoscaler.image.repository` | The image repository to pull autoscaler from | k8s.gcr.io/cluster-proportional-autoscaler-amd64 | -| `autoscaler.image.tag` | The image tag to pull autoscaler from | `1.7.1` | +| `autoscaler.image.tag` | The image tag to pull autoscaler from | `1.8.0` | | `autoscaler.image.pullPolicy` | Image pull policy for the autoscaler | IfNotPresent | | `autoscaler.priorityClassName` | Optional priority class for the autoscaler pod. `priorityClassName` used if not set. | `""` | | `autoscaler.affinity` | Affinity settings for pod assignment for autoscaler | {} | @@ -113,9 +114,9 @@ The command removes all the Kubernetes components associated with the chart and See `values.yaml` for configuration notes. Specify each parameter using the `--set key=value[,key=value]` argument to `helm install`. For example, ```console -$ helm install --name coredns \ +$ helm install coredns \ --set rbac.create=false \ - stable/coredns + coredns/coredns ``` The above command disables automatic creation of RBAC rules. @@ -123,7 +124,7 @@ The above command disables automatic creation of RBAC rules. Alternatively, a YAML file that specifies the values for the above parameters can be provided while installing the chart. For example, ```console -$ helm install --name coredns -f values.yaml stable/coredns +$ helm install coredns --namespace=kube-system coredns/coredns -f values.yaml ``` > **Tip**: You can use the default [values.yaml](values.yaml) From 2b1fb6d528f3fa3e72330b170aa73f977e8a6bbd Mon Sep 17 00:00:00 2001 From: ajayk Date: Tue, 2 Mar 2021 23:05:04 -0800 Subject: [PATCH 5/6] change readme to point to coredns helm repo and other doc fixes Signed-off-by: ajayk --- stable/coredns/README.md | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/stable/coredns/README.md b/stable/coredns/README.md index bf3a03a..ff41bef 100644 --- a/stable/coredns/README.md +++ b/stable/coredns/README.md @@ -5,7 +5,7 @@ # TL;DR; ```console -$ helm install --name coredns --namespace=kube-system stable/coredns +$ helm install coredns --namespace=kube-system coredns/coredns ``` ## Introduction @@ -25,7 +25,8 @@ This chart bootstraps a [CoreDNS](https://github.com/coredns/coredns) deployment The chart can be installed as follows: ```console -$ helm install --name coredns --namespace=kube-system stable/coredns +$ helm repo add coredns https://coredns.github.io/helm +$ helm install coredns --namespace=kube-system coredns/coredns ``` The command deploys CoreDNS on the Kubernetes cluster in the default configuration. The [configuration](#configuration) section lists various ways to override default configuration during deployment. @@ -34,7 +35,7 @@ The command deploys CoreDNS on the Kubernetes cluster in the default configurati ## Uninstalling the Chart -To uninstall/delete the `my-release` deployment: +To uninstall/delete the `coredns` deployment: ```console $ helm delete coredns @@ -47,7 +48,7 @@ The command removes all the Kubernetes components associated with the chart and | Parameter | Description | Default | |:----------------------------------------|:--------------------------------------------------------------------------------------|:------------------------------------------------------------| | `image.repository` | The image repository to pull from | coredns/coredns | -| `image.tag` | The image tag to pull from | `v1.7.1` | +| `image.tag` | The image tag to pull from | `1.8.0` | | `image.pullPolicy` | Image pull policy | IfNotPresent | | `replicaCount` | Number of replicas | 1 | | `resources.limits.cpu` | Container maximum CPU | `100m` | @@ -98,7 +99,7 @@ The command removes all the Kubernetes components associated with the chart and | `autoscaler.includeUnschedulableNodes` | Should the replicas scale based on the total number or only schedulable nodes | `false` | | `autoscaler.preventSinglePointFailure` | If true does not allow single points of failure to form | `true` | | `autoscaler.image.repository` | The image repository to pull autoscaler from | k8s.gcr.io/cluster-proportional-autoscaler-amd64 | -| `autoscaler.image.tag` | The image tag to pull autoscaler from | `1.7.1` | +| `autoscaler.image.tag` | The image tag to pull autoscaler from | `1.8.0` | | `autoscaler.image.pullPolicy` | Image pull policy for the autoscaler | IfNotPresent | | `autoscaler.priorityClassName` | Optional priority class for the autoscaler pod. `priorityClassName` used if not set. | `""` | | `autoscaler.affinity` | Affinity settings for pod assignment for autoscaler | {} | @@ -113,9 +114,9 @@ The command removes all the Kubernetes components associated with the chart and See `values.yaml` for configuration notes. Specify each parameter using the `--set key=value[,key=value]` argument to `helm install`. For example, ```console -$ helm install --name coredns \ +$ helm install coredns \ --set rbac.create=false \ - stable/coredns + coredns/coredns ``` The above command disables automatic creation of RBAC rules. @@ -123,7 +124,7 @@ The above command disables automatic creation of RBAC rules. Alternatively, a YAML file that specifies the values for the above parameters can be provided while installing the chart. For example, ```console -$ helm install --name coredns -f values.yaml stable/coredns +$ helm install coredns --namespace=kube-system coredns/coredns -f values.yaml ``` > **Tip**: You can use the default [values.yaml](values.yaml) From 662c307f903e0ac941be1a7b7adbbff850bf67ce Mon Sep 17 00:00:00 2001 From: Michael Kriese Date: Tue, 16 Mar 2021 06:53:53 +0100 Subject: [PATCH 6/6] chore: fix release path Signed-off-by: Michael Kriese --- .github/workflows/release.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/release.yaml b/.github/workflows/release.yaml index 81f598d..437f32a 100644 --- a/.github/workflows/release.yaml +++ b/.github/workflows/release.yaml @@ -33,6 +33,6 @@ jobs: - name: Run chart-releaser uses: helm/chart-releaser-action@v1.1.0 with: - charts_dir: stable/ + charts_dir: stable env: CR_TOKEN: "${{ secrets.GITHUB_TOKEN }}"