Skip to content
This repository has been archived by the owner on Aug 26, 2024. It is now read-only.

Missing document links #10

Open
fcayre opened this issue Jan 15, 2018 · 0 comments
Open

Missing document links #10

fcayre opened this issue Jan 15, 2018 · 0 comments

Comments

@fcayre
Copy link

fcayre commented Jan 15, 2018

Hi there,

when several links of a document share the same last path portion, the HAL codec (more precisely the _map_to_coreapi_key function) use the same document key to store them. The consequence is that the document misses them all but the last.

My use case is Slimpay's API where the root document uses links of the form https://api.slimpay.net/alps#<foo> where can take several different values. The key computed for all these links is "alps", and the parser overrides the previously parsed link.

I think the codec should not alter the API writter's choice regarding this key and take it as is, to avoid such caveats. What do you think?

This would obviously change the codec API so care would have to be taken to deprecate the _map_to_coreapi_key function slowly in the 1.x branch and introduce the change in the 2.x series.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant