-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
constant exponent variables #825
Comments
if this could be a priority it would really help me close out the engine model |
I agree, it is common for constants to appear both in exponents and in the usual way (e.g. in atmosphere model), and we should report those sensitivities correctly. This could also be useful for gauging sensitivity to exponent values in fitted models. @bqpd, what will this take? |
I was also just advocating fixed variables in the exponents...I thought maybe they should have a class constructor with a different name to make this clear? |
Hmm. I don't think this will take too much; we can keep notice of such exps in the varlocs and varkeys, and substitute them normally. Hmm. And I think we can avoid mmaps when calculating their sensitivities. |
But it is a modification pretty deep in the code, so it'll take some focused time. |
were there any updates on this? |
Not currently targeted for the next release, unless you can convince @whoburg |
@whoburg I think having this ability would really add to the engine model (particularly having the sensitivities to component polytropic efficiencies)...I think it could be worth building this functionality sooner rather than later for the engine paper (its also needed to get more accurate engine validation cases) |
Saw this recently in the shopping model as well...this should definitely happen, although it may not be before January. |
I support |
Aight this is going to happen now, because I would like to have sensitivities to exponents for robust. If interested, follow the varexp branch. |
Addressed in #1438 . |
I think a critical addition to the engine code is to allow variables in the exponent. Not free variables, but constants. Maybe make a class called ExpVariable to make the distinction very clear. The advantage here is being able to use substitutions and calculate sensitivties to constants in an exponent. Component efficiencies are in the exponent of the isentropic relation, which is the major motivation behind this issue.
I'm moving into the validation phase of the engine model and having to hard code sensitivities is a major hinderance.
I thought already made this an issue but couldn't find one...if I did feel free to close this.
The text was updated successfully, but these errors were encountered: