Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

constant exponent variables #825

Closed
mayork opened this issue Aug 30, 2016 · 12 comments
Closed

constant exponent variables #825

mayork opened this issue Aug 30, 2016 · 12 comments
Labels

Comments

@mayork
Copy link
Contributor

mayork commented Aug 30, 2016

I think a critical addition to the engine code is to allow variables in the exponent. Not free variables, but constants. Maybe make a class called ExpVariable to make the distinction very clear. The advantage here is being able to use substitutions and calculate sensitivties to constants in an exponent. Component efficiencies are in the exponent of the isentropic relation, which is the major motivation behind this issue.

I'm moving into the validation phase of the engine model and having to hard code sensitivities is a major hinderance.

I thought already made this an issue but couldn't find one...if I did feel free to close this.

@mayork mayork added the utopian label Aug 31, 2016
@mayork
Copy link
Contributor Author

mayork commented Aug 31, 2016

if this could be a priority it would really help me close out the engine model

@whoburg
Copy link
Collaborator

whoburg commented Sep 5, 2016

I agree, it is common for constants to appear both in exponents and in the usual way (e.g. in atmosphere model), and we should report those sensitivities correctly. This could also be useful for gauging sensitivity to exponent values in fitted models.

@bqpd, what will this take?

@whoburg whoburg added this to the Middle Release milestone Sep 5, 2016
@mayork
Copy link
Contributor Author

mayork commented Sep 5, 2016

I was also just advocating fixed variables in the exponents...I thought maybe they should have a class constructor with a different name to make this clear?

@mayork mayork changed the title exponent variables constant exponent variables Sep 5, 2016
@bqpd
Copy link
Contributor

bqpd commented Sep 5, 2016

Hmm. I don't think this will take too much; we can keep notice of such exps in the varlocs and varkeys, and substitute them normally. Hmm. And I think we can avoid mmaps when calculating their sensitivities.

@bqpd
Copy link
Contributor

bqpd commented Sep 5, 2016

But it is a modification pretty deep in the code, so it'll take some focused time.

@mayork
Copy link
Contributor Author

mayork commented Sep 14, 2016

were there any updates on this?

@bqpd
Copy link
Contributor

bqpd commented Sep 14, 2016

Not currently targeted for the next release, unless you can convince @whoburg

@mayork
Copy link
Contributor Author

mayork commented Sep 14, 2016

@whoburg I think having this ability would really add to the engine model (particularly having the sensitivities to component polytropic efficiencies)...I think it could be worth building this functionality sooner rather than later for the engine paper (its also needed to get more accurate engine validation cases)

@bqpd
Copy link
Contributor

bqpd commented Nov 30, 2016

Saw this recently in the shopping model as well...this should definitely happen, although it may not be before January.

@whoburg
Copy link
Collaborator

whoburg commented Dec 6, 2016

I support

@bqpd bqpd removed this from the Middle Release milestone Mar 21, 2018
@1ozturkbe
Copy link
Contributor

Aight this is going to happen now, because I would like to have sensitivities to exponents for robust. If interested, follow the varexp branch.

@1ozturkbe
Copy link
Contributor

Addressed in #1438 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

4 participants