-
-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop range-v3 and replace it with std::ranges
#1611
Comments
Hi @christianparpart , I would love to tackle this issue. Could you please provide more details on it? |
Oh this is great to hear. I think the following is the action list that needed to be done:
Getting rid of the dependencyIf you do a
All of those files should simply get the occurrence removed. (In case of problems, just ask us) Replacing the actual code callsThis should(tm) be as simple as replacing all Keep in mind, that Standard C++20 also provides a shortcut for p.s.: If you create a PR early, we can also give early feedback. You don't have to wait until it is fully working, in case it might take you longer. Keep in mind, you can also join us on Discord for (most of the time) realtime chatting, in case it might help. Good luck! |
Hey! Has this been fixed? I would like to give it a try. |
Hey @EKS2003. It's a pleasure to get such a positive feedback from all of you, guys. However, this ticket has already been claimed. I can recommend you #1613, even though, this is a really trivial one (I'm sorry), it yet has to be done. Apart from that, i sadly do not know how much you want to dive in, but we could surely find more, when you join us on Discord, so we can figure a good and easy ticket out for you. Many thanks from all of you. |
Hi @christianparpart , something urgent has come up, and I won't be able to work on this issue at the moment. It's great that there's already someone claiming it. You can go ahead and assign it to @EKS2003 |
@DIlkhush00 I'm sorry to hear that. Many thanks for informing us :) |
Hi @EKS2003, is there any updates? |
Some of things that we use is from c++23 standard, for example I suppose it is better to wait until we switch to c++23 and make this transition, at the moment we compile on mac with clang-15 |
We want to reduce external dependencies and embrace standards.
C++20 comes with its own
<ranges>
library, so there is no need to depend on range-v3 library anymore.Most places should be trivial to adapt. If any first-time contributor comes across this ticket, don't hesitate to talk to us on Discord, so we can help you getting on board and guide you through.
The text was updated successfully, but these errors were encountered: