Delete the Windows storage driver?

[mtrmac]

Ever since 1eba391 in Sep 2017 the driver’s test can’t compile because a addAceToSddlDacl function is missing.

Clearly no-one is even trying to make it functional.

Can we remove that code? If we ever did want to add a Windows support, the old code can always be fished out of git.

[rhatdan]

SGTM

[nalind]

That call is in the unit test which only run on Windows, so CI doesn't run them. The driver itself compiles, for whatever that's worth.

[Luap99]

To add another reason, just noticed go.opencensus.io has an expired SSL cert and thus fails new vendor in CI (or well locally if this version was not downloaded before). To work around that we must use the golang proxy to vendor and cannot use the direct mode (fedora golang default), see containers/common#2300.

Looking into why we import this package which has been archived a while ago points back here in c/storage to the windows driver. Dropping it would solve that as well AFAICS.

 go mod why go.opencensus.io
# go.opencensus.io
github.com/containers/storage/drivers/windows
github.com/Microsoft/hcsshim
github.com/Microsoft/hcsshim/internal/hcs
go.opencensus.io/trace
go.opencensus.io/internal
go.opencensus.io

[mtrmac]

microsoft/hcsshim#2136 tracks removing the dependency.

[rhatdan]

Why not just delete the support from C/S?