Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISS' processCommitted may delete a delivered certificate without sending the DeliverCert event #398

Open
ranchalp opened this issue Apr 11, 2023 · 0 comments

Comments

@ranchalp
Copy link
Contributor

The solution should be simply replacing:

var cert availabilitypb.Cert
		if len(certData) > 0 {
			if err := proto.Unmarshal(certData, &cert); err != nil {
				return nil, fmt.Errorf("cannot unmarshal availability certificate: %w", err)
			}
		}

by

var cert availabilitypb.Cert
		if len(certData) > 0 {
			if err := proto.Unmarshal(certData, &cert); err != nil {
				return eventsOut, fmt.Errorf("cannot unmarshal availability certificate: %w", err)
			}
		}

But TBD. Also I am currently updating the module to use the DSL, hence making a DSL-compatible solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant