Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI won't run required checks if ignored files are changed in a PR #120

Open
mattkram opened this issue Jul 8, 2023 · 0 comments
Open

CI won't run required checks if ignored files are changed in a PR #120

mattkram opened this issue Jul 8, 2023 · 0 comments
Labels
automation CI/CD and automation tasks

Comments

@mattkram
Copy link
Contributor

mattkram commented Jul 8, 2023

We have a branch protection rule set such that a PR cannot be merged unless the check job passes. We also have ignored paths defined to prevent running all the tests on simple changes to text files, such as the README or docs.

If a PR is made that only changes files for which the test runs are ignored, the check job never runs and the branch protection rule won't allow the PR to be merged.

Originally posted by @mattkram in #116 (comment)
@mattkram mattkram added the automation CI/CD and automation tasks label Jul 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
automation CI/CD and automation tasks
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mattkram