Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--skip-python skips boost-cpp: is it expected? #62

Open
lesteve opened this issue Dec 6, 2019 · 4 comments
Open

--skip-python skips boost-cpp: is it expected? #62

lesteve opened this issue Dec 6, 2019 · 4 comments
Labels
bug Something isn't working

Comments

@lesteve
Copy link

lesteve commented Dec 6, 2019

To reproduce:

# conda-press environment
conda create -n conda-press -c conda-forge python=3.7 conda-press -y
conda activate conda-press

# create numpy wheels
conda press --subdir linux-64 --dont-strip-symbols --skip-python eigenpy=1.6.9=py37hb21ce0d_0

Part of the conda-press output:

Skipping Python package dependency conda-forge/linux-64::boost-cpp==1.70.0=h8e57a91_2
Skipping Python package dependency conda-forge/linux-64::numpy==1.17.3=py37h95a1406_0
Skipping Python package dependency conda-forge/linux-64::boost==1.70.0=py37h9de70de_1

eigenpy depends on boost (Boost.Python is used for the Python bindings) which depends on python, is that why --skip-python skips boost and all its dependencies (including boost-cpp).

More generally, is there a recommended approach for using conda-press on packages that depends on boost?

@marcelotrevisani
Copy link
Member

not really...
It should not skip boost in this scenario (I think)
It seems to be a bug indeed

@marcelotrevisani marcelotrevisani added the bug Something isn't working label Dec 6, 2019
@marcelotrevisani
Copy link
Member

marcelotrevisani commented Dec 6, 2019

As a workaround, you can try to splicit include boost, something like

conda press --subdir linux-64 --dont-strip-symbols --add-deps boost boost-cpp --skip-python eigenpy=1.6.9=py37hb21ce0d_0

@lesteve
Copy link
Author

lesteve commented Dec 6, 2019

Thanks a lot for, it seems like boost and boost-cpp are still skipped with --add-deps boost boost-cpp:

❯ conda press --subdir linux-64 --dont-strip-symbols --add-deps boost boost-cpp --skip-python eigenpy=1.6.9=py37hb21ce0d_0 2>&1 | grep boost
Skipping Python package dependency conda-forge/linux-64::boost-cpp==1.70.0=h8e57a91_2
Skipping Python package dependency conda-forge/linux-64::boost==1.70.0=py37h9de70de_1

@marcelotrevisani
Copy link
Member

marcelotrevisani commented Dec 7, 2019

Yeap, so we have two problems here, --skip-python is getting high priority than add-deps
and --skip-python is removing boost and boost-cpp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants