Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hold meta-information for functions in Maker #26

Open
zliu41 opened this issue Feb 24, 2022 · 0 comments
Open

Hold meta-information for functions in Maker #26

zliu41 opened this issue Feb 24, 2022 · 0 comments

Comments

@zliu41
Copy link
Member

zliu41 commented Feb 24, 2022

Currently Maker is just designed for generate CoreExpr for specified functions in target category, but does not contain meta-information (module name for example). So we cannot use such information for checking equality of a function under investigation and a target function. This case happens in f . id = f simplification when checking id-ness of a function. Safer way in the case was to use temporarily made function using mkId but that's an expensive operation.
So this will make our custom simplification rules safer and more principled.

AC:
Make meta-information fields in Maker and make use of it in custom simplification like f . id = f.

(Extricated from https://kitty-hawk.atlassian.net/browse/SW-3434)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant