Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NumExpr safe limit for number of threads threads #172

Closed
JB91451 opened this issue Apr 26, 2022 · 2 comments
Closed

NumExpr safe limit for number of threads threads #172

JB91451 opened this issue Apr 26, 2022 · 2 comments
Labels

Comments

@JB91451
Copy link

JB91451 commented Apr 26, 2022

Dear all,

I run MS2PIP on a workstation which would has 24 cores and therefore set --num_cpu accordingly. however, when running the program, there is a warning that "NumExpr detected 24 cores but 'NUMEXPR_MAX_THREADS' not set, so enforcing safe limit of 8. NumExpr defaulting to 8 threads."
I guess it is not possible to set NUMEXPR_MAX_THREADS directly during the ms2pip call? If so, would it be possible to couple this value with the --num_cpu option for a future release?

Best regards,
Juergen

@RalfG
Copy link
Member

RalfG commented Jun 4, 2022

Dear Juergen,

Apologies for the late reply. Thank you for reporting this issue!

NumExpr is a downstream dependency of DeepLC. In DeepLC itself, the environment variable NUMEXPR_MAX_THREADS is set as the configured number of cores. Expected behavior would be that MS²PIP passes its --num_cpu value on to DeepLC, which would then set NUMEXPR_MAX_THREADS. As this currently does not seem to be the case, we will look into it.

In the meantime, you can set the NUMEXPR_MAX_THREADS environment variable yourself when running MS²PIP:

  • On Linux/macOS: NUMEXPR_MAX_THREADS=24 ms2pip <your ms2pip arguments>
  • On Windows PowerShell: $env:NUMEXPR_MAX_THREADS= '24'; ms2pip <your ms2pip arguments>

Best,
Ralf

@RalfG RalfG added the bug label Jun 4, 2022
@RalfG
Copy link
Member

RalfG commented Feb 27, 2023

Fixed in #193

@RalfG RalfG closed this as completed Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants