Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evaluation error message missing from detail view #3467

Open
jmsmkn opened this issue Aug 4, 2024 · 4 comments · May be fixed by #3826
Open

Evaluation error message missing from detail view #3467

jmsmkn opened this issue Aug 4, 2024 · 4 comments · May be fixed by #3826

Comments

@jmsmkn
Copy link
Member

jmsmkn commented Aug 4, 2024

No description provided.

@jmsmkn
Copy link
Member Author

jmsmkn commented Aug 4, 2024

If all the prerequisite jobs are successful we should indicate that. Would help admins determine if the problem is with the algorithm or method.

@jmsmkn
Copy link
Member Author

jmsmkn commented Aug 4, 2024

Also show the error message for failed prerequisite jobs.

@ammar257ammar
Copy link
Contributor

ammar257ammar commented Jan 28, 2025

We can add an error message section to the admin part of the evaluation details page that appears either when there are failed jobs or when the evaluation has an error message. Is that a viable solution?

Initial thought

{% if not failed_jobs and object.error_message %}
    All prequisite jobs succeeded. Evaluation failed due to the following error: {{ object.error_message }}
{% else %}
    Some jobs have failed. Check the error messages of the failed jobs above. 
{% endif %}

Case with failed jobs (with added error message column to the perquisite jobs table)

Image

Case with failed evaluation method

Image

P.S. issue discussed with Chris first

@chrisvanrun
Copy link
Contributor

I think above is a good solution.

@ammar257ammar ammar257ammar pinned this issue Feb 11, 2025
@ammar257ammar ammar257ammar unpinned this issue Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants