reindex-event command is not available anymore

[andynog]

Problem

While working on a un-related issue, I've noticed that the reindex-event command is not hooked-up in the CLI. I found this PR in the tendermint/tendermint repo where it was added to the CLI in v0.34.x.

Was this changed "lost" in CometBFT or did we disabled this command (I couldn't find any issue/PR for that in cometbft repo) ?

We need to decide if this is still a command that is useful (and if it actually works with all the storage changes made in cometbft).

If nobody complained so far, I'm wondering how important/needed this is.

The command doesn't show up in cometbft as an option:

 cometbft
BFT state machine replication for applications in any programming languages

Usage:
  cometbft [command]

Available Commands:
  debug                          A utility to kill or watch a CometBFT process while aggregating debugging data
  experimental-compact-goleveldb force compacts the CometBFT storage engine (only GoLevelDB supported)
  gen-node-key                   Generate a node key for this node and print its ID
  gen-validator                  Generate new validator keypair
  help                           Help about any command
  init                           Initialize CometBFT
  inspect                        Run an inspect server for investigating CometBFT state
  light                          Run a light client proxy server, verifying CometBFT rpc
  reset-state                    Remove all the data and WAL
  rollback                       rollback CometBFT state by one height
  show-node-id                   Show this node's ID
  show-validator                 Show this node's validator info
  start                          Run the CometBFT node
  testnet                        Initialize files for a CometBFT testnet
  unsafe-reset-all               (unsafe) Remove all the data and WAL, reset this node's validator to genesis state
  unsafe-reset-priv-validator    (unsafe) Reset this node's validator to genesis state
  version                        Show version info

But in tendermint it was available:

tendermint 
BFT state machine replication for applications in any programming languages

Usage:
  tendermint [command]

Available Commands:
  debug                          A utility to kill or watch a Tendermint process while aggregating debugging data
  experimental-compact-goleveldb force compacts the tendermint storage engine (only GoLevelDB supported)
  gen-node-key                   Generate a node key for this node and print its ID
  gen-validator                  Generate new validator keypair
  help                           Help about any command
  init                           Initialize Tendermint
  light                          Run a light client proxy server, verifying Tendermint rpc
  probe-upnp                     Test UPnP functionality
  reindex-event                  Re-index events to the event store backends
  replay                         Replay messages from WAL
  replay-console                 Replay messages from WAL in a console
  reset-state                    Remove all the data and WAL
  rollback                       rollback tendermint state by one height
  show-node-id                   Show this node's ID
  show-validator                 Show this node's validator info
  start                          Run the tendermint node
  testnet                        Initialize files for a Tendermint testnet
  unsafe-reset-all               (unsafe) Remove all the data and WAL, reset this node's validator to genesis state
  unsafe-reset-priv-validator    (unsafe) Reset this node's validator to genesis state
  version                        Show version info

Decision:

If there's agreement that this command is not needed anymore (lack of usage) or the effort to make it work again is to high (because of storage changes), we should remove it from cmd/cometbft/commands.

There is also the internal/progressbar dependency that is only there because this command and could also be removed.

This can reduce some bloat in the code.

[andynog]

This command might be helpful on re-indexing transactions to fix problems where a tx cannot be returned in a /tx or /tx_search RPC call like here

[melekes]

If nobody complained for a year, we don't need it.

[a26nine]

If nobody complained for a year, we don't need it.

Well, it's an issue, for sure! There are no publicly available archive snapshots for CosmosHub apart from QuikSync. And, the QuikSync snapshot doesn't index the tx, so it's difficult to provide "full archive" access to the customers. It will be really beneficial to have this functionality in-place.