Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update crates.io? #61

Closed
jsgf opened this issue Sep 26, 2019 · 3 comments
Closed

Update crates.io? #61

jsgf opened this issue Sep 26, 2019 · 3 comments

Comments

@jsgf
Copy link

jsgf commented Sep 26, 2019

Hi - I was about to fix the conditional dependency on winconsole, but I see it's already fixed. Could you update the crates.io version with at least that fix?

@scottmcm
Copy link

@mackwic It would also be nice to get a new version out that includes #67 because that fixes the error that just showed up in crater:

[INFO] [stderr] error[E0308]: mismatched types
[INFO] [stderr]   --> src/style.rs:76:23
[INFO] [stderr]    |
[INFO] [stderr] 76 |             .filter(|&&(ref mask, _)| (0 != (u & mask)))
[INFO] [stderr]    |                       ^^^^^^^^^^^^^^ expected tuple, found reference
[INFO] [stderr]    |
[INFO] [stderr]    = note: expected type `(u8, style::Styles)`
[INFO] [stderr]               found type `&_`
[INFO] [stderr] 
[INFO] [stderr] error[E0308]: mismatched types
[INFO] [stderr]   --> src/style.rs:77:19
[INFO] [stderr]    |
[INFO] [stderr] 77 |             .map(|&(_, value)| value)
[INFO] [stderr]    |                   ^^^^^^^^^^^ expected tuple, found reference
[INFO] [stderr]    |
[INFO] [stderr]    = note: expected type `(u8, style::Styles)`
[INFO] [stderr]               found type `&_`

https://crater-reports.s3.amazonaws.com/pr-65819/try%23b34fa46cc6fa5d46c6adcb041ebd28c7f7a374f3/reg/colored-1.8.0/log.txt

@mati865
Copy link

mati865 commented Dec 10, 2019

Published as version 1.9.

@jsgf
Copy link
Author

jsgf commented Dec 10, 2019

Thanks

@jsgf jsgf closed this as completed Dec 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants