Fix versionFlag to output to stdout #710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metachris
reviewed
Jan 29, 2025
cli/main.go
Outdated
| @@ -55,7 +55,7 @@ func Main() { | |||
| func start(_ context.Context, cmd *cli.Command) error { | |||
| // Only print the version if the flag is set | |||
| if cmd.IsSet(versionFlag.Name) { | |||
| log.Infof("mev-boost %s\n", config.Version) | |||
| fmt.Printf("mev-boost %s\n", config.Version) //nolint | |||
There was a problem hiding this comment.
probably better to do the setupLogging step first, which sets it to stdout, and keep using log.Infof.
There was a problem hiding this comment.
I think using fmt.Printf here is the right thing actually. Otherwise, the output is difficult to parse:
$ ./mev-boost --version
INFO[2025-01-31T08:45:58.966-06:00] starting mev-boost version=3c51355-dev
INFO[2025-01-31T08:45:58.966-06:00] mev-boost 3c51355-dev version=3c51355-dev
And this would break EthPillar's regex here:
MB=$(if [[ -f /etc/systemd/system/mevboost.service ]]; then printf "Mev-boost: $(mev-boost --version | sed 's/.*\s\([0-9]*\.[0-9]*\).*/\1/')"; else printf "Mev-boost: Not Installed"; fi)
There was a problem hiding this comment.
I've updated the PR to do this instead:
fmt.Fprintf(cmd.Writer, "mev-boost %s\n", config.Version)I believe this is most appropriate for CLI apps. Doesn't require //nolint either.
jtraglia
approved these changes
Jan 31, 2025
|
Thanks @coincashew! I'm going to merge this now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
Rollsback a change which affected the versionFlag output
mev-boost --versionoutputs to stdout once again.
Version output is currently outputting to stderr.
⛱ Motivation and Context
Fixes coincashew/EthPillar#47
Before
After