Commit 221f92c broke Wagtails ViewRestrictions for Collections

[viaregio]

Describe the bug

In Commit 221f92c a hook is created that bypasses the permission checks for documents in Wagtail.

Steps to reproduce

Steps to reproduce the behavior:

1. Create a Collection in Wagtail which is not Public
2. Create a Document in this Collection

Expected behavior

The document shouldn't be accessible for an anonymous user.

Additional context

The serve view from wagtail returns the result of the first hook that returns a HttpResponse.

An easy fix would be to register serve_document_directly with an order greater than 0.

[vsalvino]

Thanks for reporting this.

I'm wondering if our hook is even still needed, since it was made for such an old version of wagtail long ago?

I'd prefer to remove it if possible. Or, if you have an idea for a fix, feel free to create a pull request and I will help merge it in.