Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit environment variables #177

Open
1 of 3 tasks
stevenbuccini opened this issue May 13, 2020 · 0 comments
Open
1 of 3 tasks

Audit environment variables #177

stevenbuccini opened this issue May 13, 2020 · 0 comments

Comments

@stevenbuccini
Copy link
Contributor

This is a:

  • bug
  • enhancement
  • feature-discussion

Enhancement

Description

Currently, we have a several environment variables in a .env file in the project. These variables mainly drive our database configuration. However, Heroku will inject its own "config vars" into the environment. By having these in two separate places (specifically the URLs for pulling the data from the Board of Elections), we increase the probability that folks will update the values in one place and not the other.

Implementation

Several options off the top of my head:

  • Use dotenv everywhere
  • Move values into src/config.js
  • Hard-code values into the appropriate places in the database configuration.
@Tr3yb0 Tr3yb0 added this to the 1st Round of Enhancements milestone Oct 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants