Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLI should retry when it encounters 5XX errors #1709

Closed
com6056 opened this issue Apr 16, 2024 · 3 comments · Fixed by codecov/codecov-cli#452
Closed

CLI should retry when it encounters 5XX errors #1709

com6056 opened this issue Apr 16, 2024 · 3 comments · Fixed by codecov/codecov-cli#452
Assignees
@joseph-sentry
Labels
bug Something isn't working enhancement New feature or request

Comments

@com6056
Copy link

com6056 commented Apr 16, 2024

Love that codecov/codecov-cli#351 was tackled in codecov/codecov-cli#382! It would be great though if all 5XX status codes were retried, we just hit a few 503s today that caused some build failures so being able to automatically retry those would be perfect. Thanks!
@thomasrockhu-codecov
Copy link
Contributor

Perhaps related to codecov/feedback#335 and codecov/feedback#336

@chriscerk
Copy link

chriscerk commented Apr 18, 2024 •
edited
Loading

To add to this thread, just encountered a temporary failure today (resolved upon retry) that would benefit from automatic retries.

info - 2024-04-18 17:16:16,791 -- ci service found: circleci
info - 2024-04-18 17:16:16,934 -- Process Commit creating complete
info - 2024-04-18 17:16:16,967 -- Process Report creating complete
error - 2024-04-18 17:16:16,968 -- Report creating failed:

@thomasrockhu-codecov thomasrockhu-codecov added the enhancement New feature or request label Apr 23, 2024
@rohan-at-sentry rohan-at-sentry added bug Something isn't working and removed bug Something isn't working labels May 8, 2024
@rohan-at-sentry rohan-at-sentry transferred this issue from codecov/codecov-cli May 8, 2024
@rohan-at-sentry rohan-at-sentry added the bug Something isn't working label May 8, 2024
@rohan-at-sentry
Copy link

flagging as a bug however, this should be a quick enhancement that we can prioritize within the next few sprints.

@rohan-at-sentry rohan-at-sentry removed their assignment May 8, 2024
joseph-sentry added a commit to codecov/codecov-cli that referenced this issue Jun 3, 2024
@joseph-sentry
fix: retry all 5xx status code errors
6e4af2c 
Fixes: codecov/engineering-team#1709

Signed-off-by: joseph-sentry <[email protected]>
@joseph-sentry joseph-sentry mentioned this issue Jun 3, 2024
Merged
joseph-sentry added a commit to codecov/codecov-cli that referenced this issue Jun 4, 2024
@joseph-sentry
fix: retry all 5xx status code errors (#452)
bd4f749 
Fixes: codecov/engineering-team#1709

Signed-off-by: joseph-sentry <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joseph-sentry joseph-sentry

Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: retry all 5xx status code errors codecov/codecov-cli
5 participants
@com6056 @chriscerk @thomasrockhu-codecov @joseph-sentry @rohan-at-sentry