67 method with a default enum parameter wich type is byte does not compile

AutomaticInterface/AutomaticInterface/Builder.cs

@@ -13,6 +13,25 @@ private static string InheritDoc(ISymbol source) =>
         $"/// <inheritdoc cref=\"{source.ToDisplayString().Replace('<', '{').Replace('>', '}')}\" />"; // we use inherit doc because that should be able to fetch documentation from base classes.
 
     private static readonly SymbolDisplayFormat FullyQualifiedDisplayFormat =
+        new(
+            genericsOptions: SymbolDisplayGenericsOptions.IncludeTypeParameters,
+            memberOptions: SymbolDisplayMemberOptions.IncludeParameters
+                | SymbolDisplayMemberOptions.IncludeContainingType,
+            parameterOptions: SymbolDisplayParameterOptions.IncludeType
+                | SymbolDisplayParameterOptions.IncludeParamsRefOut
+                | SymbolDisplayParameterOptions.IncludeDefaultValue
+                | SymbolDisplayParameterOptions.IncludeName,
+            typeQualificationStyle: SymbolDisplayTypeQualificationStyle.NameAndContainingTypesAndNamespaces,
+            globalNamespaceStyle: SymbolDisplayGlobalNamespaceStyle.Included,
+            miscellaneousOptions: SymbolDisplayMiscellaneousOptions.UseSpecialTypes
+                | SymbolDisplayMiscellaneousOptions.IncludeNullableReferenceTypeModifier
+                | SymbolDisplayMiscellaneousOptions.EscapeKeywordIdentifiers
+        );
+
+    /// <summary>
+    /// We do need to be able to group shadowing and new methods/events into a single entry, hence this is missing SymbolDisplayMemberOptions.IncludeContainingType
+    /// </summary>
+    private static readonly SymbolDisplayFormat FullyQualifiedDisplayFormatForGrouping =
         new(
             genericsOptions: SymbolDisplayGenericsOptions.IncludeTypeParameters,
             memberOptions: SymbolDisplayMemberOptions.IncludeParameters,
@@ -91,7 +110,7 @@ private static void AddMethodsToInterface(List<ISymbol> members, InterfaceBuilde
             .Where(x => x.MethodKind == MethodKind.Ordinary)
             .Where(x => x.ContainingType.Name != nameof(Object))
             .Where(x => !HasIgnoreAttribute(x))
-            .GroupBy(x => x.ToDisplayString(FullyQualifiedDisplayFormat))
+            .GroupBy(x => x.ToDisplayString(FullyQualifiedDisplayFormatForGrouping))
             .Select(g => g.First())
             .ToList()
             .ForEach(method => AddMethod(codeGenerator, method));
@@ -182,7 +201,7 @@ private static void AddEventsToInterface(List<ISymbol> members, InterfaceBuilder
         members
             .Where(x => x.Kind == SymbolKind.Event)
             .OfType<IEventSymbol>()
-            .GroupBy(x => x.ToDisplayString(FullyQualifiedDisplayFormat))
+            .GroupBy(x => x.ToDisplayString(FullyQualifiedDisplayFormatForGrouping))
             .Select(g => g.First())
             .ToList()
             .ForEach(evt =>

AutomaticInterface/AutomaticInterface/InterfaceBuilder.cs

@@ -121,7 +121,9 @@ public string Build()
 
             cb.Indent();
             foreach (var method in methodInfos)
+            {
                 BuildMethod(cb, method);
+            }
 
             cb.Dedent();
 

AutomaticInterface/Tests/GeneratorTests.cs

@@ -2025,4 +2025,136 @@ public partial interface IDemoClass
             """;
         GenerateCode(code).Should().Be(expected);
     }
+
+    [Fact]
+    public void WorksWithByteEnums()
+    {
+        const string code = """
+
+            using AutomaticInterface;
+            using System;
+
+            namespace AutomaticInterfaceExample;
+
+            public enum EnumWithByteType : byte { A = 1, B = 2, C = 3 };
+
+            [GenerateAutomaticInterface]
+            public class DemoClass
+            {
+                public void MethodWithDefaultParameter(EnumWithByteType a = EnumWithByteType.B) { }
+            }
+
+            """;
+
+        const string expected = """
+            //--------------------------------------------------------------------------------------------------
+            // <auto-generated>
+            //     This code was generated by a tool.
+            //
+            //     Changes to this file may cause incorrect behavior and will be lost if the code is regenerated.
+            // </auto-generated>
+            //--------------------------------------------------------------------------------------------------
+
+            namespace AutomaticInterfaceExample
+            {
+                [global::System.CodeDom.Compiler.GeneratedCode("AutomaticInterface", "")]
+                public partial interface IDemoClass
+                {
+                    /// <inheritdoc cref="AutomaticInterfaceExample.DemoClass.MethodWithDefaultParameter(AutomaticInterfaceExample.EnumWithByteType)" />
+                    void MethodWithDefaultParameter(global::AutomaticInterfaceExample.EnumWithByteType a = global::AutomaticInterfaceExample.EnumWithByteType.B);
+
+                }
+            }
+
+            """;
+        GenerateCode(code).Should().Be(expected);
+    }
+
+    [Fact]
+    public void WorksWithByteEnumsAsReturnType()
+    {
+        const string code = """
+
+            using AutomaticInterface;
+            using System;
+
+            namespace AutomaticInterfaceExample;
+
+            public enum EnumWithByteType : byte { A = 1, B = 2, C = 3 };
+
+            [GenerateAutomaticInterface]
+            public class DemoClass
+            {
+                public EnumWithByteType MethodWithDefaultParameter(EnumWithByteType a = EnumWithByteType.B) { return a; }
+            }
+
+            """;
+
+        const string expected = """
+            //--------------------------------------------------------------------------------------------------
+            // <auto-generated>
+            //     This code was generated by a tool.
+            //
+            //     Changes to this file may cause incorrect behavior and will be lost if the code is regenerated.
+            // </auto-generated>
+            //--------------------------------------------------------------------------------------------------
+
+            namespace AutomaticInterfaceExample
+            {
+                [global::System.CodeDom.Compiler.GeneratedCode("AutomaticInterface", "")]
+                public partial interface IDemoClass
+                {
+                    /// <inheritdoc cref="AutomaticInterfaceExample.DemoClass.MethodWithDefaultParameter(AutomaticInterfaceExample.EnumWithByteType)" />
+                    global::AutomaticInterfaceExample.EnumWithByteType MethodWithDefaultParameter(global::AutomaticInterfaceExample.EnumWithByteType a = global::AutomaticInterfaceExample.EnumWithByteType.B);
+
+                }
+            }
+
+            """;
+        GenerateCode(code).Should().Be(expected);
+    }
+
+    [Fact]
+    public void WorksWithByteEnumsProperties()
+    {
+        const string code = """
+
+            using AutomaticInterface;
+            using System;
+
+            namespace AutomaticInterfaceExample;
+
+            public enum EnumWithByteType : byte { A = 1, B = 2, C = 3 };
+
+            [GenerateAutomaticInterface]
+            public class DemoClass
+            {
+               public EnumWithByteType SomeProperty { get; set; }  
+            }
+
+            """;
+
+        const string expected = """
+            //--------------------------------------------------------------------------------------------------
+            // <auto-generated>
+            //     This code was generated by a tool.
+            //
+            //     Changes to this file may cause incorrect behavior and will be lost if the code is regenerated.
+            // </auto-generated>
+            //--------------------------------------------------------------------------------------------------
+
+            namespace AutomaticInterfaceExample
+            {
+                [global::System.CodeDom.Compiler.GeneratedCode("AutomaticInterface", "")]
+                public partial interface IDemoClass
+                {
+                    /// <inheritdoc cref="AutomaticInterfaceExample.DemoClass.SomeProperty" />
+                    global::AutomaticInterfaceExample.EnumWithByteType SomeProperty { get; set; }
+
+                }
+            }
+
+            """;
+        GenerateCode(code).Should().Be(expected);
+    }
 }