Skip to content
This repository has been archived by the owner on Jun 15, 2020. It is now read-only.

Paginated applications endpoint #43

Open
3 tasks done
andrewkchan opened this issue Dec 31, 2017 · 7 comments
Open
3 tasks done

Paginated applications endpoint #43

andrewkchan opened this issue Dec 31, 2017 · 7 comments
Assignees

Comments

@andrewkchan
Copy link
Contributor

andrewkchan commented Dec 31, 2017

See (https://github.com/codebase-berkeley/ApplicationPortal/wiki/API-Endpoints):

  • Paginated /applications endpoint without other filters
  • Filtering on category id
  • Filtering on fuzzy string matching search string
@andrewkchan
Copy link
Contributor Author

@OldGuo
Copy link
Member

OldGuo commented Jan 1, 2018

@theandrewchan @bdeleonardis1 take a look at 0487f02 and let me know if i'm missing anything

@andrewkchan
Copy link
Contributor Author

For text search queries, the only thing is that I want the string matching to be more robust than just ignoring case, it should catch slight mispellings and such too. This might be non-trivial and require implementing something like elasticsearch etc.

@OldGuo
Copy link
Member

OldGuo commented Jan 2, 2018

Something like #50?

@andrewkchan
Copy link
Contributor Author

The only thing left to do for this is test it!

@andrewkchan andrewkchan added this to the week1milestone milestone Jan 5, 2018
@andrewkchan
Copy link
Contributor Author

Hey @OldGuo , I'm getting a 500 error with line 47, something about lists not having a filter attribute. I think it might have something to do with the list comprehension you added for the fuzzy string matching?

@andrewkchan andrewkchan reopened this Jan 5, 2018
@OldGuo
Copy link
Member

OldGuo commented Jan 5, 2018

My bad. I didn't update the category filter after changing things around for fuzzy matching. Pushed up a fix 18c2440

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants