KatanaV3Pool.sol cannot initializeImmutables

[howlbot-integration]

Lines of code

https://github.com/ronin-chain/katana-v3-contracts/blob/03c80179e04f40d96f06c451ea494bb18f2a58fc/src/core/KatanaV3Pool.sol#L122

Vulnerability details

There is an issue of conflict in KatanaV3Pool.sol where factory is set as address(1) but the require statement requires it to be address 0.

  constructor() {
    // disable immutables initialization
    factory = address(1);
  }


  /// @inheritdoc IKatanaV3PoolImmutables
  function initializeImmutables(address factory_, address token0_, address token1_, uint24 fee_, int24 tickSpacing_)
    public
    virtual
    override
  {
    require(factory == address(0), "AII");

The constructor sets factory to address(1), so the initializeImmutables function will always revert.
This makes it impossible to initialize the immutables as intended.

Recommended Mitigation Steps

Just change initializeImmutables to address(1)

   function initializeImmutables(address factory_, address token0_, address token1_, uint24 fee_, int24 tickSpacing_)
       public
       virtual
       override
   {
       require(factory == address(1), "AII"); // Check for address(1) instead
       factory = factory_;

Assessed type

Error

[c4-judge]

alex-ppg marked the issue as unsatisfactory:
Invalid