Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CY-5244] installing specific version is ignored by install-binary.sh #51

Open
aelnaggar opened this issue Nov 16, 2021 · 8 comments
Open
Labels
jira-issue Issue tracked on JIRA

Comments

@aelnaggar
Copy link

while trying to use helm plugin install with "--version" option, install-binary.sh always ignore it and install the latest version

getDownloadURL() {
  # Use the GitHub API to find the latest version for this project.
  local latest_url="https://api.github.com/repos/$PROJECT_GH/releases/latest
@github-actions github-actions bot added the jira-issue Issue tracked on JIRA label Nov 16, 2021
@github-actions github-actions bot changed the title installing specific version is ignored by install-binary.sh [CY-5244] installing specific version is ignored by install-binary.sh Nov 16, 2021
@github-actions
Copy link

Internal ticket created : CY-5244

@johnphilipscs
Copy link

Fixing this would be a workaround for #50 but given this issue and #50 all of our pipelines using this are failing.

@romeritoCL
Copy link

@johnphilipscs and @aelnaggar i've fixed both issues on this PR: https://github.com/codacy/helm-ssm/pull/52/files

hope we have it merged soon.

@tharun-allu
Copy link

Thanks @romeritoCL, What is the estimated time for this issue to be fixed/merged?

@romeritoCL
Copy link

@tharun-allu , it's not in my hands. I just added a PR with the fixes for 2 issues but the owners of the repository have to accept the PR and merge it.

@tharun-allu
Copy link

Any update from the repo owners on when this could be merged in?

@random1st
Copy link

it seems the project is abandoned

@maciek-codes
Copy link

@random1st if you are using EKS and need SSM integration, I recommend checking this out:
https://docs.aws.amazon.com/systems-manager/latest/userguide/integrating_csi_driver.html

I think it's a better idea compared to leaking your secrets from SSM to the k8s secret where the chart values are stored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira-issue Issue tracked on JIRA
Projects
None yet
Development

No branches or pull requests

6 participants