Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Default ignore files are always applied DOCS-663 #2063

Merged
merged 22 commits into from
Apr 2, 2024

Conversation

claudiacarpinteiro
Copy link
Contributor

@claudiacarpinteiro claudiacarpinteiro commented Mar 20, 2024

  • The default ignore files now applies even if a Codacy configuration file exists
  • Updates the list of default ignore files
  • Small improvements to the Codacy configuration file page.

👀 Live preview

@claudiacarpinteiro claudiacarpinteiro self-assigned this Mar 20, 2024
Copy link
Contributor

github-actions bot commented Mar 20, 2024

Overall readability score: 54.18 (🔴 -0.04)

File Readability
codacy-configuration-file.md 58.52 (🟢 +1.46)
ignoring-files.md 48.79 (🔴 -8.6)
View detailed metrics

🟢 - Shows an increase in readability
🔴 - Shows a decrease in readability

File Readability FRE GF ARI CLI DCRS
codacy-configuration-file.md 58.52 45.56 10.1 12.8 12.76 6.78
  🟢 +1.46 🟢 +0.71 🟢 +0.21 🟢 +0.4 🟢 +0.06 🟢 +0.1
ignoring-files.md 48.79 38.05 12.77 14.9 11.61 7.55
  🔴 -8.6 🔴 -11.81 🔴 -0.81 🔴 -2.5 🔴 -1.11 🔴 -0.02

Averages:

  Readability FRE GF ARI CLI DCRS
Average 54.18 43.03 10.86 12.38 12.54 7.88
  🔴 -0.04 🔴 -0.06 🟢 +0 🔴 -0.01 🔴 -0.01 🟢 +0
View metric targets
Metric Range Ideal score
Flesch Reading Ease 100 (very easy read) to 0 (extremely difficult read) 60
Gunning Fog 6 (very easy read) to 17 (extremely difficult read) 8 or less
Auto. Read. Index 6 (very easy read) to 14 (extremely difficult read) 8 or less
Coleman Liau Index 6 (very easy read) to 17 (extremely difficult read) 8 or less
Dale-Chall Readability 4.9 (very easy read) to 9.9 (extremely difficult read) 6.9 or less

@github-actions github-actions bot temporarily deployed to Netlify March 20, 2024 17:10 Inactive
@github-actions github-actions bot temporarily deployed to Netlify March 20, 2024 17:30 Inactive
@github-actions github-actions bot temporarily deployed to Netlify March 22, 2024 11:58 Inactive
@github-actions github-actions bot temporarily deployed to Netlify March 25, 2024 16:36 Inactive
@github-actions github-actions bot temporarily deployed to Netlify March 25, 2024 16:55 Inactive
@github-actions github-actions bot temporarily deployed to Netlify March 25, 2024 17:16 Inactive
@github-actions github-actions bot temporarily deployed to Netlify March 25, 2024 17:26 Inactive
@claudiacarpinteiro claudiacarpinteiro changed the title clean: Small improvements to Codacy configuration file page DOCS-663 clean: Improvements to Codacy configuration file page DOCS-663 Mar 26, 2024
@github-actions github-actions bot temporarily deployed to Netlify March 26, 2024 10:16 Inactive
@github-actions github-actions bot temporarily deployed to Netlify March 26, 2024 15:12 Inactive
@github-actions github-actions bot temporarily deployed to Netlify March 26, 2024 15:14 Inactive
Copy link
Contributor

@nicklem nicklem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Left some tweak suggestions.

@github-actions github-actions bot temporarily deployed to Netlify March 27, 2024 15:02 Inactive
Co-authored-by: Nicola Klemenc <[email protected]>
@github-actions github-actions bot temporarily deployed to Netlify March 27, 2024 15:15 Inactive
@github-actions github-actions bot temporarily deployed to Netlify March 27, 2024 15:19 Inactive
@github-actions github-actions bot temporarily deployed to Netlify March 27, 2024 15:24 Inactive
@github-actions github-actions bot temporarily deployed to Netlify March 27, 2024 15:26 Inactive
@github-actions github-actions bot temporarily deployed to Netlify March 27, 2024 18:33 Inactive
@claudiacarpinteiro claudiacarpinteiro added the don't merge Don't merge this pull request yet label Mar 27, 2024
@claudiacarpinteiro claudiacarpinteiro marked this pull request as ready for review March 27, 2024 18:45
@claudiacarpinteiro claudiacarpinteiro requested a review from a team as a code owner March 27, 2024 18:45
@github-actions github-actions bot temporarily deployed to Netlify March 28, 2024 10:18 Inactive
@github-actions github-actions bot temporarily deployed to Netlify March 28, 2024 18:37 Inactive
@github-actions github-actions bot temporarily deployed to Netlify March 28, 2024 18:57 Inactive
@claudiacarpinteiro claudiacarpinteiro changed the title clean: Improvements to Codacy configuration file page DOCS-663 feat: Default ignore files are always applied DOCS-663 Mar 28, 2024
@lolgab
Copy link
Contributor

lolgab commented Apr 2, 2024

The change is now in production

@nicklem nicklem removed the don't merge Don't merge this pull request yet label Apr 2, 2024
@nicklem nicklem enabled auto-merge (squash) April 2, 2024 11:25
@github-actions github-actions bot temporarily deployed to Netlify April 2, 2024 11:26 Inactive
@nicklem nicklem merged commit b4e4a61 into master Apr 2, 2024
6 of 7 checks passed
@nicklem nicklem deleted the DOCS-663-improve-configuration-file branch April 2, 2024 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants