Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: React migration - Quality PR detail page, Quality commit detail page - ALA-643 ALA-739 #1975

Conversation

nicklem
Copy link
Contributor

@nicklem nicklem commented Dec 12, 2023

Updates for the migration to React of Quality PR and commit detail pages.

👀 Live preview

Marginally affected pages and sections (screenshots, smaller edits)

🚧 To do

@nicklem nicklem self-assigned this Dec 12, 2023
Copy link
Contributor

github-actions bot commented Dec 12, 2023

Overall readability score: 53.99 (🔴 -0.05)

File Readability
which-metrics-does-codacy-calculate.md 59.87 (🔴 -0.11)
how-do-i-reanalyze-my-repository.md 70.33 (🔴 -0.93)
why-arent-duplication-metrics-being-calculated.md 48.35 (🔴 -2.09)
bitbucket-integration.md 49.13 (🟢 +0.34)
github-integration.md 52.36 (🟢 +0.4)
commits.md 50.45 (🔴 -1.66)
commits.md 50.79 (🔴 -2.96)
issues.md 63.35 (🔴 -1.21)
pull-requests.md 65.67 (🔴 -2.14)
View detailed metrics

🟢 - Shows an increase in readability
🔴 - Shows a decrease in readability

File Readability FRE GF ARI CLI DCRS
which-metrics-does-codacy-calculate.md 59.87 38.32 9.66 12 12.93 6.51
  🔴 -0.11 🔴 -0.1 🔴 -0.02 🔴 -0.1 🟢 +0.06 🟢 +0
how-do-i-reanalyze-my-repository.md 70.33 48.3 8.39 9.7 10.84 6.4
  🔴 -0.93 🔴 -7.34 🟢 +0.26 🟢 +0 🔴 -0.34 🟢 +0.1
why-arent-duplication-metrics-being-calculated.md 48.35 35.47 12 13.8 13.58 7.6
  🔴 -2.09 🔴 -0.61 🔴 -0.31 🔴 -0.4 🔴 -0.42 🔴 -0.09
bitbucket-integration.md 49.13 36.79 11.58 13.3 13.57 7.88
  🟢 +0.34 🟢 +0.91 🔴 -0.02 🟢 +0.3 🟢 +0.12 🔴 -0.12
github-integration.md 52.36 37 10.96 13.1 13.4 7.38
  🟢 +0.4 🟢 +0.82 🟢 +0.09 🟢 +0.3 🔴 -0.12 🔴 -0.05
commits.md 50.45 27.01 9.95 15.7 14.16 6.49
  🔴 -1.66 🔴 -0.21 🔴 -0.13 🔴 -0.5 🔴 -0.41 🔴 -0.03
commits.md 50.79 33.34 11.07 15.6 13.11 6.62
  🔴 -2.96 🔴 -0.71 🔴 -0.42 🔴 -0.7 🔴 -0.17 🔴 -0.27
issues.md 63.35 47.28 10.1 10.5 11.13 7.12
  🔴 -1.21 🔴 -0.21 🔴 -0.12 🔴 -0.2 🔴 -0.41 🔴 -0.03
pull-requests.md 65.67 54.42 10.3 10.1 10.26 7.22
  🔴 -2.14 🔴 -7.75 🟢 +0.13 🟢 +0 🔴 -0.4 🔴 -0.16

Averages:

  Readability FRE GF ARI CLI DCRS
Average 53.99 42.89 10.89 12.42 12.55 7.89
  🔴 -0.05 🔴 -0.08 🟢 +0 🔴 -0.01 🔴 -0.01 🟢 +0
View metric targets
Metric Range Ideal score
Flesch Reading Ease 100 (very easy read) to 0 (extremely difficult read) 60
Gunning Fog 6 (very easy read) to 17 (extremely difficult read) 8 or less
Auto. Read. Index 6 (very easy read) to 14 (extremely difficult read) 8 or less
Coleman Liau Index 6 (very easy read) to 17 (extremely difficult read) 8 or less
Dale-Chall Readability 4.9 (very easy read) to 9.9 (extremely difficult read) 6.9 or less

@nicklem nicklem force-pushed the ALA-643-doc-update-documentation-for-quality-pull-request-detail-page branch 2 times, most recently from f98a5be to cab0701 Compare December 12, 2023 17:40
@github-actions github-actions bot temporarily deployed to Netlify December 12, 2023 17:41 Inactive
@nicklem nicklem added the don't merge Don't merge this pull request yet label Dec 13, 2023
@nicklem nicklem force-pushed the ALA-643-doc-update-documentation-for-quality-pull-request-detail-page branch 2 times, most recently from 07fa4fa to 5df589d Compare December 14, 2023 10:45
@github-actions github-actions bot temporarily deployed to Netlify December 14, 2023 10:47 Inactive
@github-actions github-actions bot temporarily deployed to Netlify December 15, 2023 11:16 Inactive
@nicklem nicklem force-pushed the ALA-643-doc-update-documentation-for-quality-pull-request-detail-page branch from e1557dc to 0efa675 Compare December 20, 2023 13:32
@github-actions github-actions bot temporarily deployed to Netlify December 20, 2023 13:34 Inactive
@nicklem nicklem force-pushed the ALA-643-doc-update-documentation-for-quality-pull-request-detail-page branch from 0efa675 to bcecbfa Compare December 20, 2023 13:35
@github-actions github-actions bot temporarily deployed to Netlify December 20, 2023 13:37 Inactive
@nicklem nicklem force-pushed the ALA-643-doc-update-documentation-for-quality-pull-request-detail-page branch from bcecbfa to cc7f24a Compare December 20, 2023 13:39
@github-actions github-actions bot temporarily deployed to Netlify December 20, 2023 13:40 Inactive
@github-actions github-actions bot temporarily deployed to Netlify January 11, 2024 15:15 Inactive
@github-actions github-actions bot temporarily deployed to Netlify January 23, 2024 10:00 Inactive
@nicklem nicklem force-pushed the ALA-643-doc-update-documentation-for-quality-pull-request-detail-page branch from eda1f00 to 2f56e5b Compare March 14, 2024 12:33
@github-actions github-actions bot temporarily deployed to Netlify March 14, 2024 13:21 Inactive
@nicklem nicklem force-pushed the ALA-643-doc-update-documentation-for-quality-pull-request-detail-page branch from 09143fb to a935e20 Compare March 14, 2024 13:27
@github-actions github-actions bot temporarily deployed to Netlify March 14, 2024 13:29 Inactive
@nicklem nicklem force-pushed the ALA-643-doc-update-documentation-for-quality-pull-request-detail-page branch from 85b2575 to ec626b0 Compare March 14, 2024 13:30
@github-actions github-actions bot temporarily deployed to Netlify March 14, 2024 13:32 Inactive
@github-actions github-actions bot temporarily deployed to Netlify March 21, 2024 10:23 Inactive
@github-actions github-actions bot temporarily deployed to Netlify March 26, 2024 16:28 Inactive
nicklem added 3 commits March 27, 2024 16:34
…-for-quality-pull-request-detail-page' into ALA-643-doc-update-documentation-for-quality-pull-request-detail-page
@github-actions github-actions bot temporarily deployed to Netlify March 27, 2024 15:38 Inactive
Copy link
Member

@machadoit machadoit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM <3

@github-actions github-actions bot temporarily deployed to Netlify April 11, 2024 13:28 Inactive
@github-actions github-actions bot temporarily deployed to Netlify April 12, 2024 09:53 Inactive
@github-actions github-actions bot temporarily deployed to Netlify April 12, 2024 11:36 Inactive
@machadoit machadoit removed the don't merge Don't merge this pull request yet label Apr 15, 2024
@machadoit machadoit merged commit 51669f9 into master Apr 15, 2024
6 of 7 checks passed
@machadoit machadoit deleted the ALA-643-doc-update-documentation-for-quality-pull-request-detail-page branch April 15, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants