From c6de2b6b0aea5c2b32b6a06fe1ae415a241f5cf4 Mon Sep 17 00:00:00 2001
From: Ben Stein <115497763+sei-bstein@users.noreply.github.com>
Date: Thu, 14 Nov 2024 10:02:17 -0500
Subject: [PATCH] v3.24.2 (#205)
* Fix tracking of active prac challenge
* Minor cleanup and improved console logging
* Bug fixes and challenge report tags filter.
* Fix event horizon, game center teams, enrollment report stat summary, progress widget
* Fix issue with past games not showing ongoing ones
* WIP question sets
* More question set stuff
* Improvements to OIDC experience and support for auto log in/out.
* merge from next
* Add favicon defaults. Update theme
* Fix settings link bug, more thing
* Theme stuff
* Add settings link to user menu
* Theme stuff
* Revert "Theme stuff"
This reverts commit a26c715cc3d8189bddcee6dadfa021eec98ab708.
* Revert "Add settings link to user menu"
This reverts commit d640ee80025f01185bee6c3a5918ebf8aba3b3af.
* Revert "Theme stuff"
This reverts commit c3e3b69b652224cac176dedebc0c66b8899cf490.
* Revert "Fix settings link bug, more thing"
This reverts commit f96dc596b83743e501fdf1c6b3a603fcda5e7ba3.
* Revert "Add favicon defaults. Update theme"
This reverts commit 1b2e5a7bfe8df33772e12c017d4d592b363ec6c8.
* Rollback and reimplement oauth changes
* Update oidc settings to match topo
* Cleanup
* Update dev env settings
* Improvements to OIDC experience and support for auto log in/out.
* Restore ux improvements
* More retheme
* Retheming and initial work on name improvements.
* Update gh action versions
* Retheming and name mgmt
* Styling stuff
* Styling stuff
* Move challenge markdown
* Un 'fix' start practice button
* minor name fixes
* Name cleanup
* Finish merge from main
* More theming and fix to GBAPI#502
* More theming and markdown fix
* More style fixes
* Partially address GBAPI#254
* Return question example answers
* Auto-select first available uncompleted tab
* Standard challenge panel sticky enhancements
* Styling
* Roll back login experience changes
* Settings bug fix and hide rename cert
* Minor theme stuff
* Theming
* Add additional sticky panel toggle button
* Theming and console stuff
* Fix deploy UI issue
* WIP
* Fixed a bug that hid the 'settings' menu in user profile
* Fix create users sponsor bug and improve onclick directive
* WIP feedback templates
* Hide new feedback system for now.
* Enable certificate rename for practice.
---
.../src/app/admin/admin.module.ts | 3 +-
.../create-users-modal.component.html | 2 +-
.../create-users-modal.component.ts | 2 +-
.../feedback-editor.component.ts | 1 -
.../game-center-settings.component.html | 24 +--
.../user-registrar.component.html | 10 +-
.../user-registrar.component.ts | 7 +-
.../src/app/api/feedback-models.ts | 9 +
.../src/app/api/feedback.service.ts | 187 +++++++++++++++++-
.../status-light/status-light.component.scss | 72 +++----
.../directives/copy-on-click.directive.ts | 12 +-
.../feedback-template-picker.component.html | 173 ++++++++++++++++
.../feedback-template-picker.component.scss | 4 +
.../feedback-template-picker.component.ts | 113 +++++++++++
.../src/app/feedback/feedback.models.ts | 27 +++
.../src/app/services/modal-confirm.service.ts | 2 +-
.../challenge-questions.component.ts | 1 -
.../certificate-printer.component.html | 4 +-
.../user-page/user-page.component.ts | 3 +-
.../feedback-template-content.sample.yaml | 21 ++
projects/gameboard-ui/src/styles.scss | 7 +-
projects/gameboard-ui/src/tools/functions.ts | 2 +
22 files changed, 612 insertions(+), 74 deletions(-)
create mode 100644 projects/gameboard-ui/src/app/feedback/components/feedback-template-picker/feedback-template-picker.component.html
create mode 100644 projects/gameboard-ui/src/app/feedback/components/feedback-template-picker/feedback-template-picker.component.scss
create mode 100644 projects/gameboard-ui/src/app/feedback/components/feedback-template-picker/feedback-template-picker.component.ts
create mode 100644 projects/gameboard-ui/src/app/feedback/feedback.models.ts
create mode 100644 projects/gameboard-ui/src/assets/yaml/feedback-template-content.sample.yaml
diff --git a/projects/gameboard-ui/src/app/admin/admin.module.ts b/projects/gameboard-ui/src/app/admin/admin.module.ts
index f1f962748..83b83f3d2 100644
--- a/projects/gameboard-ui/src/app/admin/admin.module.ts
+++ b/projects/gameboard-ui/src/app/admin/admin.module.ts
@@ -89,6 +89,7 @@ import { ErrorDivComponent } from '@/standalone/core/components/error-div/error-
import { SpinnerComponent } from '@/standalone/core/components/spinner/spinner.component';
import { ToSupportCodePipe } from '@/standalone/core/pipes/to-support-code.pipe';
import { IfHasPermissionDirective } from '@/standalone/directives/if-has-permission.directive';
+import { FeedbackTemplatePickerComponent } from "../feedback/components/feedback-template-picker/feedback-template-picker.component";
@NgModule({
declarations: [
@@ -222,7 +223,6 @@ import { IfHasPermissionDirective } from '@/standalone/directives/if-has-permiss
ScoreboardModule,
SponsorsModule,
SystemNotificationsModule,
-
// standalones
ErrorDivComponent,
GameInfoBubblesComponent,
@@ -230,6 +230,7 @@ import { IfHasPermissionDirective } from '@/standalone/directives/if-has-permiss
SafeUrlPipe,
SpinnerComponent,
ToSupportCodePipe,
+ FeedbackTemplatePickerComponent
]
})
diff --git a/projects/gameboard-ui/src/app/admin/components/create-users-modal/create-users-modal.component.html b/projects/gameboard-ui/src/app/admin/components/create-users-modal/create-users-modal.component.html
index 247172880..f0358b27e 100644
--- a/projects/gameboard-ui/src/app/admin/components/create-users-modal/create-users-modal.component.html
+++ b/projects/gameboard-ui/src/app/admin/components/create-users-modal/create-users-modal.component.html
@@ -66,7 +66,7 @@
Settings
0">
- {{userIds.length}}
+ {{userIds.length}}
{{ "user" | pluralizer:userIds.length - invalidIds.length }} will be created.
diff --git a/projects/gameboard-ui/src/app/admin/components/create-users-modal/create-users-modal.component.ts b/projects/gameboard-ui/src/app/admin/components/create-users-modal/create-users-modal.component.ts
index 4af3648a4..c5ee4e95b 100644
--- a/projects/gameboard-ui/src/app/admin/components/create-users-modal/create-users-modal.component.ts
+++ b/projects/gameboard-ui/src/app/admin/components/create-users-modal/create-users-modal.component.ts
@@ -44,7 +44,7 @@ export class CreateUsersModalComponent {
private usersService: UserService,
private userRolePermissions: UserRolePermissionsService) {
this.appName = config.appName;
- this.placeholder = "// one ID per line, e.g.:\n\n3496da07-d19e-440d-a246-e35f7b7bfcac\n9a53d8cd-ef88-44c0-96b2-fc8766b518dd\n\n//and so on";
+ this.placeholder = "// one ID per line, e.g.:\n\n3496da07-d19e-440d-a246-e35f7b7bfcac\n9a53d8cd-ef88-44c0-96b2-fc8766b518dd\n// and so on";
}
async ngOnInit() {
diff --git a/projects/gameboard-ui/src/app/admin/components/feedback-editor/feedback-editor.component.ts b/projects/gameboard-ui/src/app/admin/components/feedback-editor/feedback-editor.component.ts
index e0385610b..8ea31fb13 100644
--- a/projects/gameboard-ui/src/app/admin/components/feedback-editor/feedback-editor.component.ts
+++ b/projects/gameboard-ui/src/app/admin/components/feedback-editor/feedback-editor.component.ts
@@ -51,7 +51,6 @@ export class FeedbackEditorComponent implements OnInit {
}
protected handleAboutFeedbackClick() {
-
this.modalService.openConfirm({
bodyContent: `You can use this box to configure questions that will automatically be presented to players upon conclusion of a challenge or game. Enter valid YAML to set these up.
diff --git a/projects/gameboard-ui/src/app/admin/components/game-center/game-center-settings/game-center-settings.component.html b/projects/gameboard-ui/src/app/admin/components/game-center/game-center-settings/game-center-settings.component.html
index ca8456ffc..053605553 100644
--- a/projects/gameboard-ui/src/app/admin/components/game-center/game-center-settings/game-center-settings.component.html
+++ b/projects/gameboard-ui/src/app/admin/components/game-center/game-center-settings/game-center-settings.component.html
@@ -22,7 +22,7 @@